fix(request): record modifiedBy on retry and add route tests

[fallenbagel]

Description

The retry route (POST /request/:requestId/retry) was not setting modifiedBy on the request, unlike the approve/decline route which records the acting user. This means there was no audit trail of who re-approved a failed request. Originally flagged by CodeRabbit in #2729 (review).

This PR also adds route tests for the approve, decline, and retry flows covering status transitions, modifiedBy attribution, and updatedAt advancement.

Note: This PR should be merged after #2823 since it depends on @UpdateDateColumn being in place for the updatedAt assertions.

How Has This Been Tested?

• Tested by running the unit test with fix(entities): replace MySQL-only onUpdate with @UpdateDateColumn #2823 merged locally.

▶ POST /request/:requestId/:status
  ✔ transitions to approved and records the acting user (605.417486ms)
  ✔ transitions to declined and records the acting user (540.404394ms)
✔ POST /request/:requestId/:status (1667.346427ms)
▶ POST /request/:requestId/retry
  ✔ re-approves a failed request and records the acting user (453.960331ms)
✔ POST /request/:requestId/retry (454.44532ms)
ℹ tests 3
ℹ suites 2
ℹ pass 3
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 7937.442868

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Tests

  • Added integration tests covering request status transitions (approve, decline) and retry behavior, asserting responses and persisted status, modifier, and updated timestamps.

• Bug Fixes

  • Fixed retry flow to correctly record the user who performed the retry so modifications show the proper modifier and updated timestamp.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ceede71b-df89-4e15-ad18-1fec2e5fdff2

📥 Commits

Reviewing files that changed from the base of the PR and between 0a46851 and 6cd0314.

📒 Files selected for processing (2)

• server/routes/request.test.ts
• server/routes/request.ts

✅ Files skipped from review due to trivial changes (1)

• server/routes/request.test.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• server/routes/request.ts

---

📝 Walkthrough

Walkthrough

Adds integration tests for request-status transitions and a small production fix: the /request/:requestId/retry handler now records the acting user in modifiedBy when approving a failed request.

Changes

Cohort / File(s)	Summary
Request Route Tests server/routes/request.test.ts	Adds Supertest integration tests that seed requests, authenticate as admin@seerr.dev, and verify POST /request/:requestId/approve, .../decline, and .../retry transitions: HTTP 200, response status, modifiedBy.email, and persisted status, modifiedBy, and strictly increased updatedAt.
Request Route Handler server/routes/request.ts	Minor production change: the POST /:requestId/retry handler now sets request.modifiedBy = req.user after changing request.status to APPROVED and before saving the request.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• gauthier-th

Poem

🐰 I hopped through tests with a careful paw,
Seeding states and checking law;
On retry I stamp who made it right,
A tiny mark, a timestamp bright. ✨

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(request): record modifiedBy on retry and add route tests' clearly and concisely summarizes the main changes: fixing the retry endpoint to record modifiedBy and adding comprehensive route tests.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes missing audit attribution on the request retry endpoint and adds route-level tests to validate request status transitions, modifiedBy attribution, and updatedAt changes.

Changes:

• Set modifiedBy when re-approving a request via POST /request/:requestId/retry.
• Add integration-style route tests for approve/decline and retry flows (including persistence checks).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
server/routes/request.ts	Records the acting user (modifiedBy) when retrying a request.
server/routes/request.test.ts	Adds coverage for approve/decline/retry status transitions, audit attribution, and timestamp advancement.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.