fix(generate-password): await setPassword to fix race condition

[fallenbagel]

Description

generatePassword() calls setPassword() without awaiting it. Since setPassword hashes the password asynchronously with bcrypt, the user entity can be saved before the hash completes, resulting in a null password. This is a race condition that's usually masked by the subsequent email send taking long enough, but isn't guaranteed. This PR adds the missing await to ensure the password is always set before proceeding.

• Fixes Generated password not saved when creating a local user with automatic password generation #2844

How Has This Been Tested?

(It's a one-word fix, and reliably reproducing a race condition while testing would be way more effort than the fix itself. The bug is self-evidently correct from reading the code.)

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Bug Fixes
  • Resolved an issue where password operations executed in an incorrect sequence, ensuring password generation and associated notifications complete reliably.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9eecba20-9327-4f85-9608-9decebc46694

📥 Commits

Reviewing files that changed from the base of the PR and between 2432e8d and dc0c003.

📒 Files selected for processing (1)

• server/entity/User.ts

---

📝 Walkthrough

Walkthrough

Updated the User.generatePassword() method to await the asynchronous setPassword(password) call, ensuring password hashing completes before proceeding with subsequent logic. This fixes a race condition where generated passwords were not saved to the database.

Changes

Cohort / File(s)	Summary
Password Generation Fix server/entity/User.ts	Added await keyword to setPassword(password) call in generatePassword() to prevent race condition where password hash may not complete before the method returns.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A password lost in async haste,
Now awaited, saved with taste,
One await to fix the race,
Users login with a smile on their face! ✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the core fix: adding await to setPassword to resolve a race condition in password generation.
Linked Issues check	✅ Passed	The code change directly addresses issue #2844 by adding the missing await on setPassword, ensuring password hashing completes before the user is saved.
Out of Scope Changes check	✅ Passed	The change is narrowly scoped to the identified issue; only one line was modified to add the await keyword, with no extraneous modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}