fix(emby): use static version in auth header for emby only

[fallenbagel]

Description

Emby seems to use the combination of Client, Device, DeviceId, and Version in the auth header to identify a device. Since Seerr was using getAppVersion() dynamically, every update caused Emby to see it as a new device, breaking per-user device access restrictions and requiring manual re-approval by admins. This changes the Version field to a static value so the device identity remains stable across updates.

• Fixes Emby device restriction breaks after every Seerr update due to dynamic version in auth header #2739

How Has This Been Tested?

(Did not test, but its a simple change no need to)

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Bug Fixes
  • Standardized authorization header behavior so client version is set consistently, improving compatibility with Jellyfin/Emby servers.
  • Unified header formatting for logout and avatar proxy requests to ensure auth tokens are included when available, reducing authorization failures.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 276ba784-c143-419c-9e8b-6a8e71a9fb0e

📥 Commits

Reviewing files that changed from the base of the PR and between 25cc514 and 523b04f.

📒 Files selected for processing (3)

• server/api/jellyfin.ts
• server/routes/auth.ts
• server/routes/avatarproxy.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• server/api/jellyfin.ts
• server/routes/auth.ts

---

📝 Walkthrough

Walkthrough

Adjusted how the X-Emby-Authorization / Jellyfin auth header's Version field is set: it now uses the fixed string "1.0.0" when the configured media server type is Emby, otherwise it continues to use the dynamic getAppVersion(); token inclusion remains conditional.

Changes

Cohort / File(s)	Summary
Jellyfin API header server/api/jellyfin.ts	Compute version conditionally: use "1.0.0" for Emby, else call getAppVersion(); build base X-Emby-Authorization once with Version="${version}" and append , Token="${authToken}" when present.
Auth route header server/routes/auth.ts	Logout device deletion request header now uses Version="1.0.0" when settings.main.mediaServerType === MediaServerType.EMBY, otherwise uses getAppVersion(); token reference consolidated.
Avatar proxy header server/routes/avatarproxy.ts	Image proxy init sets Version="1.0.0" for Emby and falls back to getAppVersion() otherwise; no other proxy logic changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibbled headers, made one thing stay,
Emby will greet the same device each day.
Version fixed, token snugly in view,
Little hop — no new device to pursue. 🥕

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: using a static version in the auth header specifically for Emby only, which directly addresses the core issue.
Linked Issues check	✅ Passed	The PR implements the desired behavior from issue #2739: using static version values in X-Emby-Authorization headers (1.0.0 for Emby, getAppVersion() for others) to prevent device re-registration after updates.
Out of Scope Changes check	✅ Passed	All changes consistently target the same objective: conditionally applying static versions to Emby authorization headers across three files (jellyfin.ts, auth.ts, avatarproxy.ts).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@server/api/jellyfin.ts`:
- Around line 140-142: The MediaBrowser header version is inconsistent across
call sites — extract the header builder (the stable Version="1.0.0" constant and
construction logic that uses safeDeviceId and optional authToken from the code
around authHeaderVal in server/api/jellyfin.ts) into a shared helper (e.g.,
buildMediaBrowserAuthHeader or MEDIA_BROWSER_VERSION constant) and replace the
inline constructions in server/routes/avatarproxy.ts and server/routes/auth.ts
to call that helper so all places use the same DeviceId + Version + optional
Token format; ensure the helper accepts deviceId and optional token (matching
existing safeDeviceId and authToken usage) and export it for reuse.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c35b7f53-35c2-4e9f-a908-d791e791fa8f

📥 Commits

Reviewing files that changed from the base of the PR and between 6f9b743 and c7c6d8e.

📒 Files selected for processing (1)

• server/api/jellyfin.ts

[gauthier-th]

Shouldn't we do this only for Emby? The current auth header is OK and IMO better for Jellyfin.