fix(overseerr-merge): sanitise corrupt quota values during overseerr migration

[fallenbagel]

Description

Some users migrating from Overseerr have quota fields stored as literal strings (e.g. "movieQuotaLimit") instead of integers. The root cause is unknown but is likely related to Overseerr's older TypeORM version, a past API bug, or a schema sync issue. This adds a cleanup step to the Overseerr migration flow that nulls out any corrupted values from the Overseerr database, letting affected users fall back to the global defaults correctly.

• Re Unable to toggle Seasons #2852

How Has This Been Tested?

(Not tested but should work in theory).

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Bug Fixes
  • Quota data is now validated and cleaned during Overseerr migration, preventing data integrity issues and ensuring migration stability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0ed4d991-3fe4-49b6-9154-67d4b262e2a7

📥 Commits

Reviewing files that changed from the base of the PR and between f5115da and 776c977.

📒 Files selected for processing (1)

• server/lib/overseerrMerge.ts

---

📝 Walkthrough

Walkthrough

A post-migration data cleanup step is added to checkOverseerrMerge that sanitizes corrupted quota fields by setting them to NULL when their SQLite types are text. The cleanup is wrapped in error handling that logs failures without aborting the merge flow.

Changes

Cohort / File(s)	Summary
Overseerr Merge Cleanup server/lib/overseerrMerge.ts	Added post-migration sanitization logic to remedy corrupted quota fields (movieQuotaLimit, movieQuotaDays, tvQuotaLimit, tvQuotaDays) by resetting them to NULL when stored as text types. Includes dedicated try-catch block with error logging.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Corrupted quotes, now cleaned away,
With gentle nulls to save the day,
No quota chaos in our store,
Migration merges evermore! 🌿

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly and specifically describes the main change: sanitizing corrupt quota values during Overseerr migration, which aligns with the changeset's core purpose.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gauthier-th]

LGTM