chore: upgrade to eslint v9

[michaelhthomas]

Description

It's always good to be on the newest versions of tools. While ESLint v10 is out now, some plugins aren't yet compatible. But getting off the deprecated ESLint v8 and upgrading to the new configuration format is desirable nonetheless.

The new versions of ESLint have a new config file format, so some manual migration is required. Also, newer versions of plugins have additional / fixed rules, so there are some fixes to conform with those new lints.

How Has This Been Tested?

Lint passes

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Fixes #2645

Summary by CodeRabbit

• Bug Fixes

  • Fixed pagination calculation for watchlist pages.

• Refactors

  • Improved error propagation to include original causes for better diagnostics.
  • Simplified and standardized error handling across many components.
  • Migrated ESLint configuration to the newer flat/config format.

• Chores

  • Updated development, linting, and formatting tooling and dev dependencies.

[coderabbitai]

📝 Walkthrough

Walkthrough

Replaces legacy ESLint config with a new flat config and upgrades lint tooling; applies widespread lint-driven edits including switching many catch (e) to bare catch, adding Error { cause: e } propagation, and small typing/import/pagination/UI tweaks across server and client code.

Changes

Cohort / File(s)	Summary
ESLint config & deps ./.eslintrc.js, ./eslint.config.mts, ./package.json, ./tailwind.config.js	Remove legacy .eslintrc.js, add new flat eslint.config.mts, upgrade ESLint and related devDependencies, and update lint-disable comments.
Error cause propagation server/api/animelist.ts, server/api/plextv.ts, server/api/pushover.ts, server/api/rating/..., server/api/servarr/..., server/api/tautulli.ts, server/api/themoviedb/index.ts, src/utils/pushSubscriptionHelpers.ts, src/components/Settings/SettingsMetadata.tsx	Thrown Errors now include { cause: e } in many catch paths to preserve original error context; no public API signature changes.
Unbound catch updates (remove unused error binding) server/api/jellyfin.ts, server/api/tvdb/index.ts, server/lib/imageproxy.ts, server/routes/..., server/utils/..., src/components/..., src/i18n/extractMessages.ts, src/pages/_app.tsx, ...	Convert numerous catch (e) → catch where the error was unused; behavior preserved but exception objects are no longer bound in those blocks.
Pagination & filter tweaks server/routes/discover.ts, server/routes/user/index.ts, server/routes/media.ts	Adjust page parsing to conditional fallback (defaults to 1) and remove an explicit default filter branch, slightly altering control flow for edge inputs.
Type/import/UX minor fixes server/interfaces/api/common.ts, server/lib/notifications/index.ts, server/lib/overseerrMerge.ts, server/types/custom.d.ts, server/utils/appVersion.ts, src/components/BlocklistBlock/..., src/components/Layout/...	Update lint directives, tweak type annotations/import style, use optional chaining for callbacks, rename an import alias, and small UI/refactor changes.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

• gauthier-th
• 0xSysR3ll
• fallenbagel

Poem

A rabbit nudges configs with a hop and a twitch,
Flat rules settle in, the old file in a ditch.
Errors now carry the thread of their past,
Catches grow lighter, letting unused names pass.
Hoppy linting—carrots for you! 🥕🐇

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: upgrade to eslint v9' directly and clearly summarizes the primary change in the PR - upgrading ESLint from v8 to v9.
Linked Issues check	✅ Passed	All coding requirements from issue #2645 are met: ESLint v9 upgrade complete [#2645], new configuration syntax implemented [#2645], plugins updated [#2645], and linting passes [#2645].
Out of Scope Changes check	✅ Passed	Changes are all directly related to the ESLint v9 migration: configuration format updates, dependency upgrades, and code fixes for new lint rules introduced by plugin updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[coderabbitai]

Actionable comments posted: 10

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (5)

src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsPushover.tsx (1)

91-111: ⚠️ Potential issue | 🟠 Major

Persist the selected Pushover sound.

This form renders a sound field, but these initial values and the save payload never include it. Right now a user can change the sound, get a success toast, and then have revalidate() snap the selector back because nothing was actually stored.

Proposed fix

       initialValues={{
         pushoverApplicationToken: data?.pushoverApplicationToken,
         pushoverUserKey: data?.pushoverUserKey,
+        sound: data?.pushoverSound ?? '',
         types: data?.notificationTypes.pushover ?? 0,
       }}
@@
           await axios.post(`/api/v1/user/${user?.id}/settings/notifications`, {
             pgpKey: data?.pgpKey,
             discordId: data?.discordId,
             pushbulletAccessToken: data?.pushbulletAccessToken,
             pushoverApplicationToken: values.pushoverApplicationToken,
+            pushoverSound: values.sound,
             pushoverUserKey: values.pushoverUserKey,
             telegramChatId: data?.telegramChatId,
             telegramSendSilently: data?.telegramSendSilently,
             notificationTypes: {
               pushover: values.types,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsPushover.tsx`
around lines 91 - 111, The Pushover sound field isn't persisted: add the sound
value to initialValues and include it in the save payload so changes are stored
and survive revalidate. Specifically, set initialValues to include
data?.pushoverSound (alongside pushoverApplicationToken, pushoverUserKey, types)
and in the onSubmit axios.post body include the selected sound from the form
(e.g., pushoverSound: values.sound or the actual field name used in the form).
Update references in UserNotificationsPushover (initialValues and onSubmit) to
use that field name so the backend receives and persists the selected sound.

src/components/Settings/SettingsNetwork/index.tsx (1)

149-169: ⚠️ Potential issue | 🟡 Minor

Unconditionally coercing disabled numeric fields sends NaN to the backend.

When dnsCacheForceMinTtl, dnsCacheForceMaxTtl, or proxyPort are disabled (via their feature flags), their form values remain undefined. Lines 156–157 and 162 still post Number(values.dnsCacheForceMinTtl), Number(values.dnsCacheForceMaxTtl), and Number(values.proxyPort) unconditionally, which coerces undefined to NaN.

The backend's POST handler (server/routes/settings/index.ts:91–98) performs no validation and merges the request body directly into settings. NaN persists in storage, and on app startup (server/utils/dnsCache.ts:22–23), the check typeof NaN === 'number' incorrectly passes, allowing NaN to propagate into DnsCacheManager initialization.

Guard these fields conditionally or omit them from the payload when disabled to prevent NaN from being saved.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/Settings/SettingsNetwork/index.tsx` around lines 149 - 169,
The payload currently coerces undefined to NaN by unconditionally calling
Number(...) for dnsCacheForceMinTtl, dnsCacheForceMaxTtl, and proxyPort in the
axios POST inside the SettingsNetwork component; update the request construction
so those numeric fields are only included (or converted) when their feature
flags are enabled (e.g. values.dnsCacheEnabled for
dnsCache.{forceMinTtl,forceMaxTtl} and values.proxyEnabled for proxy.port) and
otherwise omit them from the dnsCache and proxy objects in the POST body to
avoid sending NaN to the backend.

src/components/Login/AddEmailModal.tsx (1)

64-75: ⚠️ Potential issue | 🟠 Major

Surface submit failures instead of swallowing them.

This required first-login step still fails silently. If the POST rejects, the modal stays open with no field error, status message, or toast, which leaves the user without a recovery path.

I can wire this up with a Formik status/error message or a toast if you want me to sketch the patch.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/Login/AddEmailModal.tsx` around lines 64 - 75, The onSubmit
handler in AddEmailModal currently swallows errors from the
axios.post('/api/v1/auth/jellyfin') call; update the onSubmit implementation to
catch the thrown error object, call formikHelpers.setSubmitting(false), and
surface the failure to the user by either setting a Formik status (e.g.,
formikHelpers.setStatus({submitError: error.message})) or setting a field error
with formikHelpers.setFieldError('email', '...'), and/or trigger a toast (e.g.,
toast.error(error.message)); keep the successful path calling onSave()
unchanged.

src/pages/_app.tsx (1)

296-305: ⚠️ Potential issue | 🟠 Major

Only redirect on expected auth failures.

This catch currently turns any failure from /api/v1/auth/me into a /login redirect. A 5xx, timeout, or local API misconfiguration will look like an expired session and hide the real outage. Please only redirect for the unauthenticated case and let unexpected failures bubble or be logged.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/pages/_app.tsx` around lines 296 - 305, The catch block currently
redirects on any error; change it to only redirect when the failure is an
authentication error (e.g., HTTP 401/403 or a specific UnauthenticatedError) and
rethrow or log other errors so they bubble up; specifically, in the code around
the call that fetches /api/v1/auth/me (the try/catch that leads to the redirect
using router.pathname and ctx.res.writeHead/ctx.res.end), inspect the response
status or error type and perform the ctx.res.writeHead(307, { Location: '/login'
}) only when status === 401 (or 403 depending on your auth semantics), otherwise
rethrow or log the error instead of redirecting.

server/api/servarr/radarr.ts (1)

108-115: ⚠️ Potential issue | 🟡 Minor

Don't rewrite every lookup failure as "Movie not found".

This catch collapses auth errors, timeouts, and Radarr 5xxs into the same error as an actual empty lookup result. That makes add/remove failures much harder to diagnose. Only map the explicit no-result case to "Movie not found" and preserve other lookup failures as lookup errors.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/api/servarr/radarr.ts` around lines 108 - 115, The catch in the Radarr
TMDB lookup (the catch block around the get-by-TMDB-ID lookup, e.g.,
getMovieByTmdbId) incorrectly maps all failures to a generic "Movie not found";
change it so only an explicit no-result/404 case is converted to a new
Error('Movie not found') while all other errors are rethrown or preserved.
Concretely, inspect the caught error (e) for a 404 status or an empty-response
condition and only then log and throw the "Movie not found" error; otherwise log
the original error details and rethrow (or throw a wrapped error that preserves
e as the cause) so auth/timeouts/5xx retain their original diagnostics. Ensure
logger.error keeps the original error message/stack for non-404 cases and do not
swallow the original error information when rethrowing.

🧹 Nitpick comments (1)

src/components/UserList/BulkEditModal.tsx (1)

60-64: Preserve the error context before swallowing it.

This now drops all failure details, which makes bulk-update issues much harder to diagnose from client telemetry. If you don't need branching, consider keeping the error binding and forwarding it to your logger/reporting path before showing the toast.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/UserList/BulkEditModal.tsx` around lines 60 - 64, The catch
block in BulkEditModal.tsx swallows the thrown error; change the catch to
capture the error (e.g., catch (error)) and forward it to your logging/reporting
path (e.g., call the project logger or error reporter, or console.error) before
calling addToast(intl.formatMessage(messages.userfail), ...); reference the
catch block surrounding addToast and the
addToast/int1.formatMessage(messages.userfail) usage so you preserve error
context for telemetry while still showing the user-facing toast.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@server/api/themoviedb/index.ts`:
- Around line 364-366: The thrown Error messages are mislabelled — update each
rethrow so the message matches the surrounding method (e.g., replace “[TMDB]
Failed to fetch TV show details” inside the TV show method with the correct
label, and likewise fix the messages in the rethrows inside discoverMovies, the
trending aggregator, and the other wrappers). Locate the throw new Error({...})
calls inside the functions that wrap TMDB calls (e.g., the TV show details
handler, discoverMovies handler, trending/all-trending handler) and change the
string to accurately describe that function’s operation while preserving the
original e.message and cause: e.g., throw new Error(`[TMDB] Failed to <actual
operation>: ${e.message}`, { cause: e }). Ensure all occurrences noted in the
review are updated consistently.

In `@server/lib/imageproxy.ts`:
- Around line 257-259: The current catch in server/lib/imageproxy.ts swallows
all filesystem errors when reading the cache; change it to catch (err) and only
treat missing files (err.code === 'ENOENT') as an empty cache, while rethrowing
or logging and throwing any other errors so upstream failures are not silently
ignored. Locate the cache-read code path (the try surrounding the cache
read/fs.readFile call in imageproxy.ts) and update the catch to inspect
err.code, return the empty-cache behaviour for ENOENT, and propagate non-ENOENT
errors (e.g., throw err or processLogger.error(...) then throw) so real IO
problems surface.

In `@server/routes/discover.ts`:
- Around line 881-883: The page parsing currently trusts req.query.page
truthiness and can yield 0, negatives or NaN; update the logic that sets page
(used to compute offset) to parse the query value and only accept it if it's a
positive integer, otherwise default to 1 — e.g. parse Number(req.query.page) (or
parseInt), then check Number.isInteger(page) && page > 0 before assigning to
page and computing offset; keep itemsPerPage and offset calculations the same
but use the validated page value.

In `@server/routes/user/index.ts`:
- Around line 879-881: req.query.page can be non-numeric or <=0 causing page and
offset to be NaN/negative; parse and validate it before computing offset:
convert req.query.page to an integer (e.g. parseInt or Number), if the result is
not a finite positive integer default to 1, then clamp with Math.max(1,
parsedPage) and use that value for page and offset calculation (itemsPerPage and
offset variables reference) so skip/offset are always a non-negative integer.
- Around line 293-295: The catch block currently maps every exception to a 404;
change it to differentiate EntityNotFoundError from other DB errors by importing
EntityNotFoundError (from TypeORM or your ORM) and using catch (err) { if (err
instanceof EntityNotFoundError) next({ status: 404, message: 'User subscriptions
not found.' }); else next(err); } so only missing-entity errors become 404s
while other exceptions propagate to the centralized error handler; apply the
same pattern to the other catch sites mentioned (around the blocks at 317–319,
371–373, 516–518) and ensure callers using Repository.find() are not expecting
exceptions for empty results (use findOneOrFail where you intend a not-found
exception).

In `@src/components/BlocklistedTagsSelector/index.tsx`:
- Around line 279-280: The bare catch that always throws
intl.formatMessage(messages.invalidKeyword, { keywordId }) masks real errors; in
the function where you validate the TMDB keyword (the catch block that
references keywordId and messages.invalidKeyword), inspect the caught error
(e.g., use axios.isAxiosError(error)) and examine error.response/data to
determine if the backend indicates "unknown keyword" before mapping to
invalidKeyword; for any other/unexpected axios errors rethrow or throw a wrapped
error that preserves the original error object so service failures (500,
network, rate-limit) are not misreported as invalidKeyword.

In `@src/components/RequestModal/MovieRequestModal.tsx`:
- Around line 170-172: The catch block only clears isUpdating on error; update
the cancel flow in the function that performs the cancel (e.g., the cancel
handler where setIsUpdating is used, likely handleCancel or cancelRequest) to
always reset the updating state by moving setIsUpdating(false) into a finally
block or calling it after the awaited request succeeds and in catch; ensure you
still invoke onComplete() if present but do not rely on it to clear isUpdating.

In `@src/components/Settings/OverrideRule/OverrideRuleModal.tsx`:
- Around line 194-196: In OverrideRuleModal's submit catch block, don't swallow
errors — set a visible error state and surface a toast/form error before
resolving; specifically, in the catch inside the component's submit handler
(OverrideRuleModal -> onSubmit / save flow) call your error UI (e.g.,
setSaveError or form.setError for the form field and/or toast.error with the
caught error message), ensure isSaving/isLoading is reset (e.g.,
setIsSaving(false)), and either rethrow or return a rejected promise so the
caller knows the save failed instead of silently returning to idle.

In `@src/components/Settings/RadarrModal/index.tsx`:
- Around line 271-273: The catch block in the RadarrModal submit flow currently
swallows failures; update the catch to accept the error, call the modal/form
error handler (e.g. setFormError or setErrorState) or trigger a toast with the
error message, ensure any submitting flag (e.g. setSubmitting) is cleared, and
do not proceed to reset/close the modal or resolve the submit handler; instead
return or rethrow after surfacing the error so the user sees the failure. Use
the existing submit handler (handleSubmit/onSave) and modal close/reset
functions in this file to locate where to stop closure and where to set the
error.

In `@src/components/Settings/SonarrModal/index.tsx`:
- Around line 307-309: The catch block in the SonarrModal submit flow currently
swallows errors; change it to catch (err) and surface the failure by setting the
form/error state and stopping the spinner — e.g., call the existing toast/error
UI (toast.error) or set a form-level error (setError or setSubmitError) with a
descriptive message including err.message, and ensure isSubmitting or submitting
state is set to false; do not treat the request as successful. Locate the submit
handler in SonarrModal (the async submit/handleSubmit function) and update its
catch to set the error UI and reset submitting state instead of leaving it
empty.

---

Outside diff comments:
In `@server/api/servarr/radarr.ts`:
- Around line 108-115: The catch in the Radarr TMDB lookup (the catch block
around the get-by-TMDB-ID lookup, e.g., getMovieByTmdbId) incorrectly maps all
failures to a generic "Movie not found"; change it so only an explicit
no-result/404 case is converted to a new Error('Movie not found') while all
other errors are rethrown or preserved. Concretely, inspect the caught error (e)
for a 404 status or an empty-response condition and only then log and throw the
"Movie not found" error; otherwise log the original error details and rethrow
(or throw a wrapped error that preserves e as the cause) so auth/timeouts/5xx
retain their original diagnostics. Ensure logger.error keeps the original error
message/stack for non-404 cases and do not swallow the original error
information when rethrowing.

In `@src/components/Login/AddEmailModal.tsx`:
- Around line 64-75: The onSubmit handler in AddEmailModal currently swallows
errors from the axios.post('/api/v1/auth/jellyfin') call; update the onSubmit
implementation to catch the thrown error object, call
formikHelpers.setSubmitting(false), and surface the failure to the user by
either setting a Formik status (e.g., formikHelpers.setStatus({submitError:
error.message})) or setting a field error with
formikHelpers.setFieldError('email', '...'), and/or trigger a toast (e.g.,
toast.error(error.message)); keep the successful path calling onSave()
unchanged.

In `@src/components/Settings/SettingsNetwork/index.tsx`:
- Around line 149-169: The payload currently coerces undefined to NaN by
unconditionally calling Number(...) for dnsCacheForceMinTtl,
dnsCacheForceMaxTtl, and proxyPort in the axios POST inside the SettingsNetwork
component; update the request construction so those numeric fields are only
included (or converted) when their feature flags are enabled (e.g.
values.dnsCacheEnabled for dnsCache.{forceMinTtl,forceMaxTtl} and
values.proxyEnabled for proxy.port) and otherwise omit them from the dnsCache
and proxy objects in the POST body to avoid sending NaN to the backend.

In
`@src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsPushover.tsx`:
- Around line 91-111: The Pushover sound field isn't persisted: add the sound
value to initialValues and include it in the save payload so changes are stored
and survive revalidate. Specifically, set initialValues to include
data?.pushoverSound (alongside pushoverApplicationToken, pushoverUserKey, types)
and in the onSubmit axios.post body include the selected sound from the form
(e.g., pushoverSound: values.sound or the actual field name used in the form).
Update references in UserNotificationsPushover (initialValues and onSubmit) to
use that field name so the backend receives and persists the selected sound.

In `@src/pages/_app.tsx`:
- Around line 296-305: The catch block currently redirects on any error; change
it to only redirect when the failure is an authentication error (e.g., HTTP
401/403 or a specific UnauthenticatedError) and rethrow or log other errors so
they bubble up; specifically, in the code around the call that fetches
/api/v1/auth/me (the try/catch that leads to the redirect using router.pathname
and ctx.res.writeHead/ctx.res.end), inspect the response status or error type
and perform the ctx.res.writeHead(307, { Location: '/login' }) only when status
=== 401 (or 403 depending on your auth semantics), otherwise rethrow or log the
error instead of redirecting.

---

Nitpick comments:
In `@src/components/UserList/BulkEditModal.tsx`:
- Around line 60-64: The catch block in BulkEditModal.tsx swallows the thrown
error; change the catch to capture the error (e.g., catch (error)) and forward
it to your logging/reporting path (e.g., call the project logger or error
reporter, or console.error) before calling
addToast(intl.formatMessage(messages.userfail), ...); reference the catch block
surrounding addToast and the addToast/int1.formatMessage(messages.userfail)
usage so you preserve error context for telemetry while still showing the
user-facing toast.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5c90f366-e312-44f4-acf2-af992c2e69f1

📥 Commits

Reviewing files that changed from the base of the PR and between f047cab and 2c9e6c4.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (83)

• .eslintrc.js
• eslint.config.mts
• package.json
• server/api/animelist.ts
• server/api/jellyfin.ts
• server/api/plextv.ts
• server/api/pushover.ts
• server/api/rating/imdbRadarrProxy.ts
• server/api/rating/rottentomatoes.ts
• server/api/servarr/base.ts
• server/api/servarr/radarr.ts
• server/api/servarr/sonarr.ts
• server/api/tautulli.ts
• server/api/themoviedb/index.ts
• server/api/tvdb/index.ts
• server/interfaces/api/common.ts
• server/lib/imageproxy.ts
• server/lib/notifications/index.ts
• server/lib/overseerrMerge.ts
• server/routes/avatarproxy.ts
• server/routes/discover.ts
• server/routes/media.ts
• server/routes/user/index.ts
• server/types/custom.d.ts
• server/utils/appDataVolume.ts
• server/utils/appVersion.ts
• src/components/BlocklistBlock/index.tsx
• src/components/BlocklistedTagsSelector/index.tsx
• src/components/Discover/CreateSlider/index.tsx
• src/components/Discover/DiscoverSliderEdit/index.tsx
• src/components/Discover/index.tsx
• src/components/IssueDetails/IssueComment/index.tsx
• src/components/IssueDetails/index.tsx
• src/components/IssueModal/CreateIssueModal/index.tsx
• src/components/Layout/UserDropdown/MiniQuotaDisplay/index.tsx
• src/components/Login/AddEmailModal.tsx
• src/components/Login/JellyfinLogin.tsx
• src/components/Login/LocalLogin.tsx
• src/components/MovieDetails/index.tsx
• src/components/NotificationTypeSelector/index.tsx
• src/components/RequestCard/index.tsx
• src/components/RequestList/RequestItem/index.tsx
• src/components/RequestModal/CollectionRequestModal.tsx
• src/components/RequestModal/MovieRequestModal.tsx
• src/components/RequestModal/TvRequestModal.tsx
• src/components/Settings/Notifications/NotificationsDiscord.tsx
• src/components/Settings/Notifications/NotificationsEmail.tsx
• src/components/Settings/Notifications/NotificationsGotify/index.tsx
• src/components/Settings/Notifications/NotificationsNtfy/index.tsx
• src/components/Settings/Notifications/NotificationsPushbullet/index.tsx
• src/components/Settings/Notifications/NotificationsPushover/index.tsx
• src/components/Settings/Notifications/NotificationsSlack/index.tsx
• src/components/Settings/Notifications/NotificationsTelegram.tsx
• src/components/Settings/Notifications/NotificationsWebPush/index.tsx
• src/components/Settings/Notifications/NotificationsWebhook/index.tsx
• src/components/Settings/OverrideRule/OverrideRuleModal.tsx
• src/components/Settings/RadarrModal/index.tsx
• src/components/Settings/SettingsJobsCache/index.tsx
• src/components/Settings/SettingsMain/index.tsx
• src/components/Settings/SettingsMetadata.tsx
• src/components/Settings/SettingsNetwork/index.tsx
• src/components/Settings/SettingsPlex.tsx
• src/components/Settings/SettingsUsers/index.tsx
• src/components/Settings/SonarrModal/index.tsx
• src/components/Setup/JellyfinSetup.tsx
• src/components/Setup/index.tsx
• src/components/TitleCard/index.tsx
• src/components/UserList/BulkEditModal.tsx
• src/components/UserList/JellyfinImportModal.tsx
• src/components/UserList/PlexImportModal.tsx
• src/components/UserList/index.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsDiscord.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsEmail.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsPushbullet.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsPushover.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsTelegram.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsWebPush/index.tsx
• src/components/UserProfile/UserSettings/UserPasswordChange/index.tsx
• src/components/UserProfile/UserSettings/UserPermissions/index.tsx
• src/i18n/extractMessages.ts
• src/pages/_app.tsx
• src/utils/pushSubscriptionHelpers.ts
• tailwind.config.js

💤 Files with no reviewable changes (2)

• .eslintrc.js
• server/routes/media.ts

[Copilot]

Pull request overview

This PR upgrades the repo’s linting toolchain to ESLint v9 and migrates configuration from legacy .eslintrc to the new flat config format, along with a set of code tweaks to satisfy updated lint rules.

Changes:

• Upgrade ESLint and related plugins/deps; add a new eslint.config.mts flat config and remove .eslintrc.js.
• Update various catch blocks and error construction (including cause) to satisfy newer TypeScript ESLint rules.
• Fix watchlist pagination page parsing logic (server-side) and apply minor refactors/renames prompted by new linting rules.

Reviewed changes

Copilot reviewed 81 out of 84 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
eslint.config.mts	Introduces ESLint v9 flat config with TS/React/Next/a11y/FormatJS rules.
package.json	Bumps ESLint ecosystem deps and adds new config-related packages.
pnpm-lock.yaml	Locks updated dependency graph for ESLint v9 and plugins.
.eslintrc.js	Removed legacy ESLint config.
server/routes/user/index.ts	Updates watchlist pagination page parsing.
server/routes/discover.ts	Updates watchlist pagination page parsing.
Various src/** and server/** files	Lint-driven refactors (unused catch vars removed, optional chaining, error cause, etc.).

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[coderabbitai]

Actionable comments posted: 4

♻️ Duplicate comments (1)

src/components/Settings/OverrideRule/OverrideRuleModal.tsx (1)

194-196: ⚠️ Potential issue | 🟠 Major

Surface submit failures instead of silently ignoring them.

Line 194–196 still swallows save errors, so users get no failure feedback when create/update fails.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/Settings/OverrideRule/OverrideRuleModal.tsx` around lines 194
- 196, In OverrideRuleModal's submit handler (the try/catch around the
create/update call) replace the empty catch by capturing the thrown error,
calling the component's error state setter (e.g., setSubmitError or setError)
with a user-friendly message plus the error.message, ensure any loading flag is
cleared (e.g., setIsSaving(false) or setLoading(false)), and surface the failure
to the user via the existing error UI or by invoking an onError/onFailure
callback or toast; do not silently swallow the error.

🧹 Nitpick comments (2)

src/components/Settings/Notifications/NotificationsWebPush/index.tsx (1)

73-77: Consider logging the error for debugging purposes.

Switching to bare catch satisfies the lint rule for unused variables, but discarding the error entirely makes debugging failed API calls harder. If the codebase has a logger available, you could capture and log the error while still satisfying the lint rule.

-          } catch {
+          } catch (e) {
+            // eslint-disable-next-line no-console
+            console.error('Failed to save web push settings:', e);
             addToast(intl.formatMessage(messages.webpushsettingsfailed), {

If the lint-driven bare catch approach is intentional across the codebase for consistency, this is fine as-is.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/Settings/Notifications/NotificationsWebPush/index.tsx` around
lines 73 - 77, The catch block currently swallows the error; change it from a
bare catch to catch (error) and log the error before showing the toast — e.g.
call the existing logger (logger.error(error, 'webpush settings save failed'))
or console.error(error) and then call
addToast(intl.formatMessage(messages.webpushsettingsfailed), { appearance:
'error', autoDismiss: true }); keep the rest of the flow unchanged so debugging
information is preserved while the user-facing toast remains the same.

src/utils/pushSubscriptionHelpers.ts (1)

107-109: Normalize caught values before reading .message property.

Lines 107, 156, and 187 access error.message directly from caught values, which is brittle since JavaScript allows throwing any value, not just Error instances. Create a helper function to safely normalize caught values:

♻️ Proposed refactor

+const getErrorMessage = (error: unknown): string =>
+  error instanceof Error ? error.message : String(error);
+
 ...
-      throw new Error(`[SW] Resubscribe failed: ${error.message}`, {
+      throw new Error(`[SW] Resubscribe failed: ${getErrorMessage(error)}`, {
         cause: error,
       });
 ...
-      `Issue subscribing to push notifications: ${error.message}`,
+      `Issue subscribing to push notifications: ${getErrorMessage(error)}`,
       { cause: error }
     );
 ...
-      `Issue unsubscribing to push notifications: ${error.message}`,
+      `Issue unsubscribing to push notifications: ${getErrorMessage(error)}`,
       { cause: error }
     );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/utils/pushSubscriptionHelpers.ts` around lines 107 - 109, Create a small
helper (e.g., normalizeCaughtError or getErrorMessage) that accepts any caught
value and returns a safe Error-like object or at minimum a string message (use
value instanceof Error ? value.message : String(value || 'Unknown error')); then
replace direct reads of error.message in the failing throw at `[SW] Resubscribe
failed: ${error.message}` and the other two occurrences (lines flagged 156 and
187) to use this helper so thrown Error messages and the cause are always safe
and informative.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@server/api/animelist.ts`:
- Around line 177-181: The catch block that throws "Failed to download
Anime-List mapping" uses e.message unsafely; change the catch to accept unknown
and narrow the error before accessing message (e.g., check if e instanceof Error
to read e.message, otherwise use String(e) as a fallback) and pass the original
error as the cause (casting/typing appropriately) so the thrown Error uses a
safe, well-typed message and a valid cause; update the catch in the Anime-List
download block (the try/catch that currently throws `Failed to download
Anime-List mapping: ${e.message}`) accordingly.
- Around line 156-160: The catch block that throws `new Error("Failed to load
Anime-List mappings: ${e.message}", { cause: e })` uses the untyped `e`; change
it to narrow `e` before reading `message` and before setting `cause` (e.g. check
`e instanceof Error`), fall back to `String(e)` or a default message when it's
not an Error, and only pass `cause: e` if `e` is an Error (or leave cause
undefined otherwise) so TypeScript strict `useUnknownInCatchVariables` rules are
satisfied.

In `@server/api/pushover.ts`:
- Around line 50-54: The catch block in server/api/pushover.ts currently uses
e.message unsafely; change the error extraction in the catch where the Pushover
sounds are retrieved to a safe form (e.g., if (e instanceof Error) msg =
e.message; else msg = String(e)) and use that msg when constructing the new
Error(`[Pushover] Failed to retrieve sounds: ${msg}`, { cause: e }); keep the
original throw and cause but replace direct e.message access with the
narrowed/normalized message.

In `@server/api/rating/imdbRadarrProxy.ts`:
- Around line 193-198: In the catch block that throws the new Error in
server/api/rating/imdbRadarrProxy.ts (the one using catch (e) and referencing
e.message), narrow the error safely by treating e as unknown and extracting the
message with a guard (e.g. const msg = e instanceof Error ? e.message :
String(e)); then throw the Error using that msg and pass the original error as
the cause; replace direct e.message access with this safe extraction to avoid
unsafe property access on unknowns.

---

Duplicate comments:
In `@src/components/Settings/OverrideRule/OverrideRuleModal.tsx`:
- Around line 194-196: In OverrideRuleModal's submit handler (the try/catch
around the create/update call) replace the empty catch by capturing the thrown
error, calling the component's error state setter (e.g., setSubmitError or
setError) with a user-friendly message plus the error.message, ensure any
loading flag is cleared (e.g., setIsSaving(false) or setLoading(false)), and
surface the failure to the user via the existing error UI or by invoking an
onError/onFailure callback or toast; do not silently swallow the error.

---

Nitpick comments:
In `@src/components/Settings/Notifications/NotificationsWebPush/index.tsx`:
- Around line 73-77: The catch block currently swallows the error; change it
from a bare catch to catch (error) and log the error before showing the toast —
e.g. call the existing logger (logger.error(error, 'webpush settings save
failed')) or console.error(error) and then call
addToast(intl.formatMessage(messages.webpushsettingsfailed), { appearance:
'error', autoDismiss: true }); keep the rest of the flow unchanged so debugging
information is preserved while the user-facing toast remains the same.

In `@src/utils/pushSubscriptionHelpers.ts`:
- Around line 107-109: Create a small helper (e.g., normalizeCaughtError or
getErrorMessage) that accepts any caught value and returns a safe Error-like
object or at minimum a string message (use value instanceof Error ?
value.message : String(value || 'Unknown error')); then replace direct reads of
error.message in the failing throw at `[SW] Resubscribe failed:
${error.message}` and the other two occurrences (lines flagged 156 and 187) to
use this helper so thrown Error messages and the cause are always safe and
informative.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8593618c-304c-49e2-b8ac-07fb07e97078

📥 Commits

Reviewing files that changed from the base of the PR and between 733364b and a6cca63.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (83)

• .eslintrc.js
• eslint.config.mts
• package.json
• server/api/animelist.ts
• server/api/jellyfin.ts
• server/api/plextv.ts
• server/api/pushover.ts
• server/api/rating/imdbRadarrProxy.ts
• server/api/rating/rottentomatoes.ts
• server/api/servarr/base.ts
• server/api/servarr/radarr.ts
• server/api/servarr/sonarr.ts
• server/api/tautulli.ts
• server/api/themoviedb/index.ts
• server/api/tvdb/index.ts
• server/interfaces/api/common.ts
• server/lib/imageproxy.ts
• server/lib/notifications/index.ts
• server/lib/overseerrMerge.ts
• server/routes/avatarproxy.ts
• server/routes/discover.ts
• server/routes/media.ts
• server/routes/user/index.ts
• server/types/custom.d.ts
• server/utils/appDataVolume.ts
• server/utils/appVersion.ts
• src/components/BlocklistBlock/index.tsx
• src/components/BlocklistedTagsSelector/index.tsx
• src/components/Discover/CreateSlider/index.tsx
• src/components/Discover/DiscoverSliderEdit/index.tsx
• src/components/Discover/index.tsx
• src/components/IssueDetails/IssueComment/index.tsx
• src/components/IssueDetails/index.tsx
• src/components/IssueModal/CreateIssueModal/index.tsx
• src/components/Layout/UserDropdown/MiniQuotaDisplay/index.tsx
• src/components/Login/AddEmailModal.tsx
• src/components/Login/JellyfinLogin.tsx
• src/components/Login/LocalLogin.tsx
• src/components/MovieDetails/index.tsx
• src/components/NotificationTypeSelector/index.tsx
• src/components/RequestCard/index.tsx
• src/components/RequestList/RequestItem/index.tsx
• src/components/RequestModal/CollectionRequestModal.tsx
• src/components/RequestModal/MovieRequestModal.tsx
• src/components/RequestModal/TvRequestModal.tsx
• src/components/Settings/Notifications/NotificationsDiscord.tsx
• src/components/Settings/Notifications/NotificationsEmail.tsx
• src/components/Settings/Notifications/NotificationsGotify/index.tsx
• src/components/Settings/Notifications/NotificationsNtfy/index.tsx
• src/components/Settings/Notifications/NotificationsPushbullet/index.tsx
• src/components/Settings/Notifications/NotificationsPushover/index.tsx
• src/components/Settings/Notifications/NotificationsSlack/index.tsx
• src/components/Settings/Notifications/NotificationsTelegram.tsx
• src/components/Settings/Notifications/NotificationsWebPush/index.tsx
• src/components/Settings/Notifications/NotificationsWebhook/index.tsx
• src/components/Settings/OverrideRule/OverrideRuleModal.tsx
• src/components/Settings/RadarrModal/index.tsx
• src/components/Settings/SettingsJobsCache/index.tsx
• src/components/Settings/SettingsMain/index.tsx
• src/components/Settings/SettingsMetadata.tsx
• src/components/Settings/SettingsNetwork/index.tsx
• src/components/Settings/SettingsPlex.tsx
• src/components/Settings/SettingsUsers/index.tsx
• src/components/Settings/SonarrModal/index.tsx
• src/components/Setup/JellyfinSetup.tsx
• src/components/Setup/index.tsx
• src/components/TitleCard/index.tsx
• src/components/UserList/BulkEditModal.tsx
• src/components/UserList/JellyfinImportModal.tsx
• src/components/UserList/PlexImportModal.tsx
• src/components/UserList/index.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsDiscord.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsEmail.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsPushbullet.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsPushover.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsTelegram.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsWebPush/index.tsx
• src/components/UserProfile/UserSettings/UserPasswordChange/index.tsx
• src/components/UserProfile/UserSettings/UserPermissions/index.tsx
• src/i18n/extractMessages.ts
• src/pages/_app.tsx
• src/utils/pushSubscriptionHelpers.ts
• tailwind.config.js

💤 Files with no reviewable changes (2)

• .eslintrc.js
• server/routes/media.ts

✅ Files skipped from review due to trivial changes (2)

• server/utils/appVersion.ts
• tailwind.config.js

🚧 Files skipped from review as they are similar to previous changes (42)

• src/components/Settings/SettingsUsers/index.tsx
• server/lib/overseerrMerge.ts
• src/components/Login/AddEmailModal.tsx
• src/components/Settings/Notifications/NotificationsNtfy/index.tsx
• src/components/Login/JellyfinLogin.tsx
• server/api/servarr/radarr.ts
• src/components/UserList/JellyfinImportModal.tsx
• src/components/Settings/SettingsPlex.tsx
• src/components/UserProfile/UserSettings/UserPasswordChange/index.tsx
• src/components/Layout/UserDropdown/MiniQuotaDisplay/index.tsx
• src/components/BlocklistedTagsSelector/index.tsx
• src/components/Settings/RadarrModal/index.tsx
• src/components/Settings/Notifications/NotificationsGotify/index.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsWebPush/index.tsx
• eslint.config.mts
• server/routes/user/index.ts
• src/components/Discover/DiscoverSliderEdit/index.tsx
• src/components/Settings/SettingsMetadata.tsx
• src/components/UserList/index.tsx
• server/interfaces/api/common.ts
• src/components/TitleCard/index.tsx
• src/components/Discover/index.tsx
• src/components/RequestCard/index.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsEmail.tsx
• src/i18n/extractMessages.ts
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsDiscord.tsx
• src/components/Login/LocalLogin.tsx
• server/types/custom.d.ts
• src/components/Settings/Notifications/NotificationsPushover/index.tsx
• server/routes/discover.ts
• src/components/RequestList/RequestItem/index.tsx
• src/components/UserProfile/UserSettings/UserNotificationSettings/UserNotificationsPushover.tsx
• src/components/UserList/PlexImportModal.tsx
• src/components/Settings/SonarrModal/index.tsx
• src/components/MovieDetails/index.tsx
• src/components/IssueDetails/IssueComment/index.tsx
• src/components/Setup/JellyfinSetup.tsx
• server/lib/imageproxy.ts
• src/components/Settings/SettingsJobsCache/index.tsx
• src/components/RequestModal/MovieRequestModal.tsx
• src/components/Settings/Notifications/NotificationsPushbullet/index.tsx
• server/api/tvdb/index.ts

[fallenbagel]

LGTM

[cypress]

seerr    Run #3303

Run Properties:   Passed #3303  •  36243a0deb: chore: upgrade to eslint v9 (#2574)

Project	seerr
Branch Review	develop
Run status	Passed #3303
Run duration	02m 26s
Commit	36243a0deb: chore: upgrade to eslint v9 (#2574)
Committer	Michael Thomas
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	31
View all changes introduced in this branch ↗︎