fix(media): exclude null mediaAddedAt entries

[0xSysR3ll]

Description

For some reasons, the database can contain media entries with mediaAddedAt = null. When used in the "recently added" slider, these entries were sorted first due to NULL-first ordering, preventing genuinely recent added media from appearing.

This PR fixes the issue by adding a non-null condition to the sorting logic.

• Fixes #XXXX

How Has This Been Tested?

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Refactor
  • Improved media query filtering and sorting logic to handle multiple filter combinations more reliably. Enhanced the handling of status filters and media sorting to ensure accurate results in all scenarios.

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified media query construction to support dynamic where clause filtering. Adds TypeORM imports (IsNull, Not) and implements conditional logic that builds the where clause based on statusFilter presence or mediaAdded sorting requirement, ensuring appropriate null checks.

Changes

Cohort / File(s)	Summary
Media Query Filtering server/routes/media.ts	Enhanced where clause construction with conditional status filtering and null checks for mediaAddedAt when sorting by mediaAdded; added TypeORM IsNull and Not imports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A query grows more clever still,
With clauses bending to our will,
Where null and status dance in grace,
Media finds its rightful place! ✨

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title directly describes the main fix: excluding null mediaAddedAt entries from the media ordering logic.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

server/routes/media.ts (1)

71-77: Please add a regression test for this query path.

Recommend adding coverage for sort=mediaAdded to assert null mediaAddedAt rows are excluded, and another case combining it with a status filter.

Also applies to: 82-82

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/routes/media.ts` around lines 71 - 77, Add regression tests exercising
the query path that builds whereClause (the mediaAddedAt and statusFilter logic)
to ensure rows with null mediaAddedAt are excluded when sort=mediaAdded and that
combining sort=mediaAdded with a statusFilter correctly filters by both
mediaAddedAt IS NOT NULL and the provided status; create two tests calling the
media listing endpoint (one with query param sort=mediaAdded, another with
sort=mediaAdded&status=<STATUS>) seeded with fixtures containing both null and
non-null mediaAddedAt plus various statuses and assert the response only
contains non-null mediaAddedAt entries and, for the combined test, only entries
matching the requested status too.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@server/routes/media.ts`:
- Around line 71-77: Add regression tests exercising the query path that builds
whereClause (the mediaAddedAt and statusFilter logic) to ensure rows with null
mediaAddedAt are excluded when sort=mediaAdded and that combining
sort=mediaAdded with a statusFilter correctly filters by both mediaAddedAt IS
NOT NULL and the provided status; create two tests calling the media listing
endpoint (one with query param sort=mediaAdded, another with
sort=mediaAdded&status=<STATUS>) seeded with fixtures containing both null and
non-null mediaAddedAt plus various statuses and assert the response only
contains non-null mediaAddedAt entries and, for the combined test, only entries
matching the requested status too.

---

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f74306e and a8fe238.

📒 Files selected for processing (1)

• server/routes/media.ts

[Copilot]

Pull request overview

This PR fixes an issue in the media listing endpoint where items with mediaAddedAt = null would appear first when sorting by “recently added” (due to NULL-first ordering), pushing truly recent items out of view.

Changes:

• Add a mediaAddedAt IS NOT NULL constraint when sort=mediaAdded is selected.
• Refactor the route’s where construction to support combining the status filter with the new non-null constraint.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.