fix(movie,tv): respect display language for trailers

[0xSysR3ll]

Description

This PR fixes an issue where trailers didn't always match the user's display language.

Where we previously requested trailers in both English and the user's preferred language, we now prioritize the user's preference and fall back to English if none are found.

• Fixes Change trailer language #1469

How Has This Been Tested?

Tested with a movie for which TMDB doesn't provide French trailers => English is provided as fallback (War of the Worlds)
Tested with a movie for which TMDB provides French trailers => Only French trailers are returned (Hoppers)

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Bug Fixes
  • Localized detail pages now fall back to English trailers when no localized trailers are found, making trailers appear more reliably for movies and TV shows.
  • English trailers are appended to localized results when available; fallback errors are ignored so original localized data remains unchanged if the fallback fails.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The TMDB client now requests videos using only the requested language for include_video_language. For non-English requests, if no "Trailer" videos are found in the localized data, it fetches English videos and appends missing English trailers to the localized data.videos, preserving caching and ignoring fallback errors.

Changes

Cohort / File(s)	Summary
TMDB API client server/api/themoviedb/index.ts	Use include_video_language: language for initial movie/TV detail fetch. If language !== 'en' and no videos of type "Trailer" are present, perform a secondary fetch with include_video_language: 'en', identify English Trailer videos not present in the localized set, and append them to data.videos. Preserve existing caching and ignore fallback failures.

Sequence Diagram(s)

sequenceDiagram
    rect rgba(200,200,255,0.5)
    participant Client
    end
    rect rgba(200,255,200,0.5)
    participant Server
    end
    rect rgba(255,200,200,0.5)
    participant TMDB
    end

    Client->>Server: Request movie/TV details (language = X)
    Server->>TMDB: Fetch details (include_video_language = X)
    TMDB-->>Server: Return details + videos
    alt language != 'en' and no Trailer in videos
        Server->>TMDB: Fetch details (include_video_language = 'en')
        TMDB-->>Server: Return English videos
        Server-->>Server: Append English Trailer(s) not present in localized videos
    end
    Server-->>Client: Return details (videos possibly augmented with English trailers)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• fallenbagel
• gauthier-th

Poem

🐰 I hopped to fetch a trailer tune,
In your tongue I searched by moon,
If none were found where you reside,
I hopped for English, brought them inside,
Now screens hum with extra cheer — hop, premiere! 🎬✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(movie,tv): respect display language for trailers' clearly and specifically describes the main change: ensuring trailers respect the user's display language preference.
Linked Issues check	✅ Passed	The PR implements the core objective from issue #1469 by prioritizing trailers in the user's display language and falling back to English only when necessary, matching the desired behavior exactly.
Out of Scope Changes check	✅ Passed	All changes are scoped to implementing language-aware trailer fetching for both movies and TV shows with English fallback logic, directly addressing issue #1469 without introducing unrelated modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/components/MovieDetails/index.tsx`:
- Around line 214-216: The current selection logic in trailerVideo uses
.filter(...).sort(...)[0], which picks the highest-resolution trailer (by size)
and can override the API's locale-preferred ordering; change it to preserve the
API order by selecting the first trailer returned for type 'Trailer' instead of
sorting by size—i.e., use the original data.relatedVideos order (e.g.,
Array.prototype.find or take the first element from the filtered array) so
trailerVideo reflects the API's preferred locale-based choice.

In `@src/components/TvDetails/index.tsx`:
- Around line 209-211: The current logic in TvDetails (variable trailerVideo)
re-sorts data.relatedVideos by size, which overrides the backend/localization
ordering; remove the sort and preserve backend order by selecting the first
Trailer entry from data.relatedVideos (e.g., use find or take filter(...)[0]) so
the API's preferred locale trailer is honored instead of picking the largest
size.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cb170539-8f4a-4422-a100-d0bd27f73b85

📥 Commits

Reviewing files that changed from the base of the PR and between d5c5f1f and 4c781a5.

📒 Files selected for processing (2)

• src/components/MovieDetails/index.tsx
• src/components/TvDetails/index.tsx

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@server/api/themoviedb/index.ts`:
- Line 289: The TMDB request currently sets include_video_language to only the
user's locale (include_video_language), which removes the required English
fallback; update the request payloads that set include_video_language (the
occurrences around include_video_language: language at both locations shown) to
include English as a fallback (e.g., include both the user's language and "en")
so TMDB returns English videos when localized ones are missing; after adding the
fallback you can optionally prioritize/filter client-side to prefer the user's
language over English when presenting results.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 47f8bb05-8d30-401f-8e17-9bf7d9e7b2a8

📥 Commits

Reviewing files that changed from the base of the PR and between 4c781a5 and f1ee007.

📒 Files selected for processing (1)

• server/api/themoviedb/index.ts

We need to discuss this change

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

server/api/themoviedb/index.ts (1)

296-296: Consider handling English regional variants.

The condition language !== 'en' doesn't account for variants like 'en-US' or 'en-GB'. For these locales, the code would make an unnecessary fallback request to fetch 'en' videos even though the content is likely the same.

Suggested improvement

-      if (
-        language !== 'en' &&
+      if (
+        !language.startsWith('en') &&
         !data.videos?.results?.some((v) => v.type === 'Trailer')
       ) {

Apply the same change at line 344 for TV shows.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/api/themoviedb/index.ts` at line 296, The code currently treats any
non-exact 'en' locale (language !== 'en') as requiring a fallback request;
change the check to detect English variants by using a startsWith or prefix
check (e.g., !language || !language.startsWith('en') → or invert: !(language &&
language.startsWith('en'))), so locales like 'en-US' and 'en-GB' are treated as
English and won't trigger the extra fetch; update the condition that currently
reads language !== 'en' in the movie video fallback and apply the identical fix
to the TV show fallback at the second occurrence.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@server/api/themoviedb/index.ts`:
- Around line 343-362: The TV fallback currently replaces all video entries with
the English fallback; instead, fetch only English trailers and merge them into
the existing data.videos.results while preserving other localized video types.
In the block that calls this.get<TmdbTvDetails> and receives fallback.videos,
filter fallback.videos.results for items with type === 'Trailer' (and not
already present in data.videos.results by id), then append those trailers to
data.videos.results (initializing arrays/objects as needed) rather than
assigning data.videos = fallback.videos.
- Around line 295-314: The fallback currently overwrites data.videos with
fallback.videos, discarding non-trailer videos in the original language;
instead, merge only trailers from the fallback into data.videos.results: find
fallback.videos.results where v.type === 'Trailer' and append those that aren't
already present (compare by id or key) to data.videos.results, preserving
existing non-trailer entries; use the same block around get<TmdbMovieDetails>
and update data.videos.results rather than assigning data.videos wholesale.

---

Nitpick comments:
In `@server/api/themoviedb/index.ts`:
- Line 296: The code currently treats any non-exact 'en' locale (language !==
'en') as requiring a fallback request; change the check to detect English
variants by using a startsWith or prefix check (e.g., !language ||
!language.startsWith('en') → or invert: !(language &&
language.startsWith('en'))), so locales like 'en-US' and 'en-GB' are treated as
English and won't trigger the extra fetch; update the condition that currently
reads language !== 'en' in the movie video fallback and apply the identical fix
to the TV show fallback at the second occurrence.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2b666982-9db2-41a8-9799-fd49867ad51c

📥 Commits

Reviewing files that changed from the base of the PR and between f1ee007 and 1f5a3a4.

📒 Files selected for processing (1)

• server/api/themoviedb/index.ts

[Copilot]

Pull request overview

Updates TMDB movie/TV detail fetching to request videos only in the selected UI language by default, and then fall back to English videos when no localized trailer is available.

Changes:

• Change include_video_language for movie and TV details from “<language>, en” to just the requested language.
• Add a second TMDB request that fetches English videos when no trailer is present in the requested language.
• Replace the returned videos payload with the fallback response when triggered.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

server/api/themoviedb/index.ts (1)

295-326: Consider extracting the fallback fetch/merge into one helper.

getMovie() and getTvShow() now carry the same fallback request, dedupe, and merge code. Pulling that into a private helper would keep both paths in lockstep and make future changes here less error-prone.

Also applies to: 356-388

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/api/themoviedb/index.ts` around lines 295 - 326, getMovie() and
getTvShow() duplicate the fallback fetch/dedupe/merge logic; extract that logic
into a single private helper (e.g., mergeFallbackVideos or
fetchAndMergeFallbackVideos) that accepts the primary data object (data), the
resource id (movieId/tvId), the type tag if needed, and language, performs the
fallback GET (using this.get with append_to_response:'videos' and
include_video_language:'en'), dedupes by video.key, and merges english fallback
trailers into data.videos.results; replace the duplicated blocks in getMovie()
and getTvShow() with calls to this new helper so both code paths remain in sync.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@server/api/themoviedb/index.ts`:
- Around line 289-297: The locale check currently uses strict equality (language
!== 'en') in the video fallback guards, which misses regional English locales;
update both occurrences to use prefix matching (!language.startsWith('en')) so
callers passing locales like "en-US" are treated as English and avoid
unnecessary fallback API calls—locate the checks inside the movie/tv video fetch
functions (the same pattern as used in getMovieGenres() and getTvGenres()) and
replace language !== 'en' with !language.startsWith('en') in both places.

---

Nitpick comments:
In `@server/api/themoviedb/index.ts`:
- Around line 295-326: getMovie() and getTvShow() duplicate the fallback
fetch/dedupe/merge logic; extract that logic into a single private helper (e.g.,
mergeFallbackVideos or fetchAndMergeFallbackVideos) that accepts the primary
data object (data), the resource id (movieId/tvId), the type tag if needed, and
language, performs the fallback GET (using this.get with
append_to_response:'videos' and include_video_language:'en'), dedupes by
video.key, and merges english fallback trailers into data.videos.results;
replace the duplicated blocks in getMovie() and getTvShow() with calls to this
new helper so both code paths remain in sync.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e277a042-fc1b-4962-8656-b05a790eaa9a

📥 Commits

Reviewing files that changed from the base of the PR and between 1f5a3a4 and 05f1858.

📒 Files selected for processing (1)

• server/api/themoviedb/index.ts

[coderabbitai]

🧹 Nitpick comments (1)

server/api/themoviedb/index.ts (1)

299-327: Consider extracting the trailer fallback merge into a shared helper.

The movie and TV paths now carry the same fallback fetch/dedupe/append logic. Pulling that into one helper would make future TMDB trailer-selection changes easier to keep consistent.

Also applies to: 364-392

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/api/themoviedb/index.ts` around lines 299 - 327, Extract the duplicate
trailer fallback/merge logic into a shared helper (e.g.,
mergeLocalizedAndFallbackVideos) and call it from both the movie and TV paths
instead of duplicating the block in the try handlers; the helper should accept
the primary response object (data) and the fallback response (fallback), compute
localizedVideos and localizedVideoKeys, filter fallback.videos?.results for type
=== 'Trailer' and not in the key set, and then return or mutate data.videos to
include the merged results (preserve existing results order and keep existing
fields by spreading ...(data.videos ?? { results: [] })). Replace the in-place
merging code in the movie handler (the try block that calls this.get and then
performs the dedupe/append) and the analogous TV handler (the block at lines
referenced in the comment) with a call to mergeLocalizedAndFallbackVideos to
avoid duplication and keep behavior identical.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@server/api/themoviedb/index.ts`:
- Around line 299-327: Extract the duplicate trailer fallback/merge logic into a
shared helper (e.g., mergeLocalizedAndFallbackVideos) and call it from both the
movie and TV paths instead of duplicating the block in the try handlers; the
helper should accept the primary response object (data) and the fallback
response (fallback), compute localizedVideos and localizedVideoKeys, filter
fallback.videos?.results for type === 'Trailer' and not in the key set, and then
return or mutate data.videos to include the merged results (preserve existing
results order and keep existing fields by spreading ...(data.videos ?? {
results: [] })). Replace the in-place merging code in the movie handler (the try
block that calls this.get and then performs the dedupe/append) and the analogous
TV handler (the block at lines referenced in the comment) with a call to
mergeLocalizedAndFallbackVideos to avoid duplication and keep behavior
identical.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3dfbd1c6-87e2-4326-b553-04cdc2bbee96

📥 Commits

Reviewing files that changed from the base of the PR and between 05f1858 and 6920881.

📒 Files selected for processing (1)

• server/api/themoviedb/index.ts

[fallenbagel]

LGTM