File permission option for file consumer#26
Closed
xenph wants to merge 1 commit intosegmentio:masterfrom
Closed
Conversation
Author
There was a problem hiding this comment.
I had some trouble making the tests pass without trimming this first. I believe this should affect anything else, and might actually make the test suite slightly more portable. But let me know if you don't like it and I can remove it.
Contributor
There was a problem hiding this comment.
Seems ok to me. What was the failure without this?
… the file consumer, which will be used instead of 0777 on the chmod().
Closed
f2prateek
reviewed
Nov 4, 2016
| $this->assertFalse($tracked); | ||
| } | ||
|
|
||
| function testFileSecurity() { |
Contributor
There was a problem hiding this comment.
Could you rename this to testFileSecurityCustom?
Contributor
|
Closing for now as this is out of date, but feel free to re-open against master with any changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will allow the user to pass an optional "filepermissions" parameter to the file consumer, which will be used instead of 0777 on the chmod().
The parameter must be passed as an octal. Following to same conventions as the chmod() function