Closed
Conversation
There is no reason for this library to set permissions on the file. Sysadmins can manage what permissions should be when the file is created, and what permissions are required for the cron to read/rename/write the file.
Contributor
|
It seems like a reasonable request but the tradeoff for us as a library is making something work out of the box vs adding another step to the README. For instance here's a PR that actually even goes one step further and makes this value configurable #26 |
Contributor
|
I think the best option is to update https://github.com/segmentio/analytics-php/pull/26/files to have a mode/option where the library doesn't |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library does not need to set permissions on the file. Sysadmins can manage what permissions should be when the file is created, and what permissions are required for the cron to read/rename/write the file.