Fix timestamp implementation for microseconds#94
Merged
nd4p90x merged 4 commits intosegmentio:masterfrom Feb 2, 2021
Merged
Conversation
Following changes and fixed issues are included: - Line 134: Wrong php method reference - Line 162: The cast to int is redundant as seconds are already casted in date() call at line 165 - Line 163: Casting microseconds part to int strips out leading zeros, resulting in converting a timestamp from `1504784759.0124` to `1504784759.124` as an example. - Line 614: The date format string misses the dot as separator between seconds and microseconds, resulting in datetime object far in the future when parsing in `send.php` (File consumer)
Contributor
|
Tracking internally in JIRA as well https://segment.atlassian.net/browse/LIB-140 |
nd4p90x
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following changes and fixed issues are included:
1504784759.0124to1504784759.124e.g.send.php(File consumer)