Skip to content

Fix timestamp implementation for microseconds #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nd4p90x merged 4 commits into from
Feb 2, 2021
Merged

Fix timestamp implementation for microseconds #94

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8fd5f6
Fix timestamp implementation for microseconds
alexleutgoeb Sep 7, 2017
5dda3dc
Merge branch 'master' into patch-1
nd4p90x Jan 6, 2021
dc53901
Merge branch 'master' into patch-1
nd4p90x Jan 13, 2021
bc28410
Merge branch 'master' into patch-1
nd4p90x Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/Segment/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public function getConsumer() {
* Formats a timestamp by making sure it is set
* and converting it to iso8601.
*
* The timestamp can be time in seconds `time()` or `microseconds(true)`.
* The timestamp can be time in seconds `time()` or `microtime(true)`.
* any other input is considered an error and the method will return a new date.
*
* Note: php's date() "u" format (for microseconds) has a bug in it
Expand Down Expand Up @@ -186,9 +186,9 @@ private function formatTime($ts) {
}

// microtime(true)
$sec = (int)$parts[0];
$usec = (int)$parts[1];
$fmt = sprintf("Y-m-d\\TH:i:s%sP", $usec);
$sec = $parts[0];
$usec = $parts[1];
$fmt = sprintf("Y-m-d\TH:i:s.%sP", $usec);

return date($fmt, (int)$sec);
}
Expand Down