ci: make Codecov uploads safe on forks (skip when token/secrets unavailable)#2293
Closed
Pray4Lovee wants to merge 40 commits intosei-protocol:mainfrom
Closed
ci: make Codecov uploads safe on forks (skip when token/secrets unavailable)#2293Pray4Lovee wants to merge 40 commits intosei-protocol:mainfrom
Pray4Lovee wants to merge 40 commits intosei-protocol:mainfrom
Conversation
- Add comprehensive tests for event signatures - Add tests for event data encoding - Add tests for error handling in EmitEVMLog - Improve EmitEVMLog error handling for nil EVM and StateDB
…aking-evm-event-propagation
…rotocol/sei-chain into feat/staking-evm-event-propagation
* Make flushing receipt synchrnous * Add unit test and config for flush receipt sync * Fix config parsing * Fix config test
…2-payment-confirmation and conflict resolutions
…lement.yml-workflow Add Proof of Keeper settlement workflow
|
We truly appreciate your contribution and the time you’ve invested in this PR. |
|
This PR is being closed due to inactivity, but we want to acknowledge and thank you for the effort you’ve put in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov uploads were failing on forked PRs and protected branches due to missing secrets and tokenless restrictions.
This change makes the Codecov step conditional so it only uploads when it’s safe and permitted, and skips gracefully on forked PRs (or when no token is available).
Why: GitHub never exposes repository secrets to workflows triggered from forks. Also, tokenless uploads aren’t allowed to protected branches. This was causing red CI.
What changed
CODECOV_TOKENonly when available.Validation
Matrix tested locally and via this branch:
CODECOV_TOKEN) → ✅ upload with tokenExpected log lines:
fail_ci_if_error: false)Security considerations
secrets.CODECOV_TOKENwhen present.Impact & tradeoffs
Alternatives considered
github-actions[bot]: not ideal; broad bypass weakens protections.Rollback plan
Revert this PR. No data/schema migrations; safe instant rollback.
Follow-ups (optional)
CODECOV_TOKENin repo/org secrets to ensure uploads on protected branches.Checklist
fail_ci_if_error: falseset