Skip to content

Make flushing receipt synchronous#2250

Merged
yzang2019 merged 8 commits intomainfrom
yzang/sync-flush-receipt
Jul 24, 2025
Merged

Make flushing receipt synchronous#2250
yzang2019 merged 8 commits intomainfrom
yzang/sync-flush-receipt

Conversation

@yzang2019
Copy link
Copy Markdown
Contributor

@yzang2019 yzang2019 commented Jul 22, 2025

Describe your changes and provide context

This PR add a new emv rpc config to make receipt flush synchronous so that we don't have inconsistency between receipts and block txs.

Testing performed to validate your change

Added unit test for synchronous flush

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.10%. Comparing base (b16814c) to head (dfb1a0d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/keeper/receipt.go 61.53% 4 Missing and 1 partial ⚠️
app/app.go 40.00% 1 Missing and 2 partials ⚠️
evmrpc/config.go 25.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
- Coverage   60.12%   60.10%   -0.02%     
==========================================
  Files         309      309              
  Lines       29995    30010      +15     
==========================================
+ Hits        18035    18039       +4     
- Misses      10685    10692       +7     
- Partials     1275     1279       +4     
Files with missing lines Coverage Δ
app/app.go 65.91% <40.00%> (-0.13%) ⬇️
evmrpc/config.go 85.57% <25.00%> (-2.43%) ⬇️
x/evm/keeper/receipt.go 68.75% <61.53%> (-2.33%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yzang2019 yzang2019 requested a review from jewei1997 July 23, 2025 01:44
@yzang2019 yzang2019 enabled auto-merge (squash) July 24, 2025 01:20
@yzang2019 yzang2019 merged commit 7002611 into main Jul 24, 2025
49 of 50 checks passed
@yzang2019 yzang2019 deleted the yzang/sync-flush-receipt branch July 24, 2025 01:32
yzang2019 added a commit that referenced this pull request Jul 24, 2025
* main:
  Optimization: CreateAccount only clears state if code hash exists (#2255)
  chore: bump btcec to v2.3.2, x/crypto to v0.31.0 (#2238)
  Use legacy transaction decoder for historical height (#2234)
  Make flushing receipt synchronous (#2250)
  [SEI-9824][SEI-9825] Update oracle MidBlock logic (#2251)
  Fix data race in price-feeder websocket controller (#2256)
  Add tests for price feeder providers (#2253)
  remove arm64 target from CI due to slow running (#2254)
  Harden solo precompile (#2236)
  Add CODEOWNERS (#2237)
  Require MsgClaim sender to match signer (#2232)
  Remove writeset estimation to alleviate AccAddress mutex contention (#2239)
philipsu522 pushed a commit that referenced this pull request Aug 6, 2025
* Make flushing receipt synchrnous

* Add unit test and config for flush receipt sync

* Fix config parsing

* Fix config test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants