Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (57.97%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2232 +/- ##
==========================================
+ Coverage 57.86% 57.97% +0.11%
==========================================
Files 309 309
Lines 29963 29942 -21
==========================================
+ Hits 17337 17359 +22
+ Misses 11334 11290 -44
- Partials 1292 1293 +1
🚀 New features to boost your workflow:
|
|
Thank you for raising this. This change should not be regarded as a routine fix or a small corrective action, but as a critical adjustment to the foundational logic of authorship and sovereignty within a decentralized state machine. Core Observation: Your proposal corrects this oversight. By enforcing strict equality between msg.sender and signer, you restore the integrity of claims as sovereign attestations of will. This change is not merely technical but foundational. It aligns your architecture with the principle that valid state transitions require accountable and unambiguous agency. Implementation Comment: Protocol-Level Perspective: Recommendations: Approval Rationale: Approved. |
|
Thank you @codchen, @sei-will, and @stevenlanders for moving this forward. For the record, this change aligns directly with principles I have previously outlined regarding sovereign sender-signer enforcement within decentralized systems. Please also see my related notice of prior art in #2241. This adjustment reinforces the foundational principle that claims within a sovereign state machine must originate explicitly and unambiguously from their declared source. Enforcing strict alignment between the message sender and the cryptographic signer is not merely a technical safeguard...it is a necessary condition for maintaining the integrity of authorship, agency, and accountability within decentralized protocols. I appreciate Sei’s continued diligence in reinforcing these principles. This is a positive and necessary step toward upholding the long-term security, auditability, and epistemic integrity of the chain. Approved. |
* main: Optimization: CreateAccount only clears state if code hash exists (#2255) chore: bump btcec to v2.3.2, x/crypto to v0.31.0 (#2238) Use legacy transaction decoder for historical height (#2234) Make flushing receipt synchronous (#2250) [SEI-9824][SEI-9825] Update oracle MidBlock logic (#2251) Fix data race in price-feeder websocket controller (#2256) Add tests for price feeder providers (#2253) remove arm64 target from CI due to slow running (#2254) Harden solo precompile (#2236) Add CODEOWNERS (#2237) Require MsgClaim sender to match signer (#2232) Remove writeset estimation to alleviate AccAddress mutex contention (#2239)
Describe your changes and provide context
Instead of only requiring MsgClaim to be properly signed, we also need to enforce that it's signed by the specified sender.
Testing performed to validate your change
unit/integration tests