Use legacy transaction decoder for historical height#2234
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2234 +/- ##
==========================================
- Coverage 60.12% 60.09% -0.04%
==========================================
Files 309 309
Lines 29995 30026 +31
==========================================
+ Hits 18035 18043 +8
- Misses 10685 10704 +19
- Partials 1275 1279 +4
🚀 New features to boost your workflow:
|
blindchaser
approved these changes
Jul 21, 2025
udpatil
reviewed
Jul 22, 2025
app/app.go
Outdated
| return app.encodingConfig.TxConfig | ||
| } | ||
| // use current for post v6.0.6 heights | ||
| if height >= 175827094 { |
Collaborator
There was a problem hiding this comment.
Where did we get this height from? When I spot checked explorer info for the upgrade proposals, it says v6.1.0 (the upgrade following v6.0.6) was height 153_240_070 https://sei.explorers.guru/proposal/102
Collaborator
Author
There was a problem hiding this comment.
updated - I pasted the wrong height. We want it to be v6.0.6's upgrade height
codchen
requested review from
philipsu522,
sei-will and
stevenlanders
as code owners
udpatil
approved these changes
Jul 24, 2025
philipsu522
approved these changes
Jul 24, 2025
app/app.go
Outdated
| return app.encodingConfig.TxConfig | ||
| } | ||
| // use current for post v6.0.6 heights | ||
| if height >= 151573570 { |
Contributor
There was a problem hiding this comment.
nit - can we name this int v6.0.6UpgradeHeight
yzang2019
added a commit
that referenced
this pull request
Jul 24, 2025
* main: Optimization: CreateAccount only clears state if code hash exists (#2255) chore: bump btcec to v2.3.2, x/crypto to v0.31.0 (#2238) Use legacy transaction decoder for historical height (#2234) Make flushing receipt synchronous (#2250) [SEI-9824][SEI-9825] Update oracle MidBlock logic (#2251) Fix data race in price-feeder websocket controller (#2256) Add tests for price feeder providers (#2253) remove arm64 target from CI due to slow running (#2254) Harden solo precompile (#2236) Add CODEOWNERS (#2237) Require MsgClaim sender to match signer (#2232) Remove writeset estimation to alleviate AccAddress mutex contention (#2239)
philipsu522
pushed a commit
that referenced
this pull request
Jul 25, 2025
* Use legacy tx decoder when appropriate * bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
In upgrade v6.0.6, we added a limit on how many recursions the transaction decoder can go through to prevent certain type of attacks. However this made historical blocks with transactions that were encoded with higher number of recursions unable to decode, so we reintroduced the old decoder only for usage on historical queries.
Testing performed to validate your change
unit tests