Fix integration tests for sei-db record not found#2366
Closed
Fix integration tests for sei-db record not found#2366
Conversation
Co-authored-by: kartik <kartik@seinetwork.io>
|
Cursor Agent can help with this pull request. Just |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (59.18%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## BumpSeidb #2366 +/- ##
==========================================
Coverage 60.47% 60.47%
==========================================
Files 314 314
Lines 31071 31096 +25
==========================================
+ Hits 18790 18806 +16
- Misses 10973 10978 +5
- Partials 1308 1312 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR resolves integration test failures stemming from a
sei-dbupdate (sei-protocol/sei-db#105) that now errors ("record not found") for missing keys.Key changes:
x/evm/keeper/receipt.gonow treatssei-db's "record not found" as a normal miss, falling back to legacy KV store for receipt lookups.evmrpc/utils.gointroducessafeVersionExiststo prevent RPC calls (e.g.,eth_call,debug_call) from crashing on missing state versions by handling "record not found" panics.MigrateLegacyReceiptsBatchto correctly parse hashes and useApplyChangeset, addedDeleteTransientReceipt, and updatedgetTestKeyringsignature.These adjustments harden the chain code against the new
sei-dbbehavior, ensuring stability and test pass rates.Testing performed to validate your change
go build ./...go test ./evmrpcx/evm/keeper