Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Surface Read Errors#105

Merged
Kbhat1 merged 5 commits intomainfrom
PebbleSurfaceErrors
Sep 3, 2025
Merged

Surface Read Errors#105
Kbhat1 merged 5 commits intomainfrom
PebbleSurfaceErrors

Conversation

@Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Sep 2, 2025

Describe your changes and provide context

  • Instead of silent return when key not found, surface an error
  • When key doesn't exist, request is earlier version or its deleted, return an error on get request

Testing performed to validate your change

  • Verifying on node

@Kbhat1 Kbhat1 requested a review from yzang2019 September 2, 2025 14:10
@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.68%. Comparing base (2533953) to head (542619f).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
ss/pebbledb/db.go 66.66% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   63.67%   63.68%           
=======================================
  Files          28       28           
  Lines        4047     4045    -2     
=======================================
- Hits         2577     2576    -1     
+ Misses       1171     1170    -1     
  Partials      299      299           
Files with missing lines Coverage Δ
ss/pebbledb/db.go 57.28% <66.66%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@yzang2019 yzang2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kbhat1 Kbhat1 merged commit de1d7fe into main Sep 3, 2025
6 of 7 checks passed
Kbhat1 added a commit that referenced this pull request Oct 8, 2025
Kbhat1 added a commit that referenced this pull request Oct 8, 2025
#118)

This reverts commit de1d7fe, reversing
changes made to 2533953.

## Describe your changes and provide context
- Revert surfacing errors from db layer since the rpc / keeper / store
layer hard codes a lot of handling of record not found and there needs
to be a larger refactor
- Can re introduce this error after a redesign and consideration of
impact

## Testing performed to validate your change
- Verified in unit tests and on node
yzang2019 added a commit that referenced this pull request Oct 8, 2025
* main:
  Revert "Merge pull request #105 from sei-protocol/PebbleSurfaceErrors" (#118)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants