Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Revert "Merge pull request #105 from sei-protocol/PebbleSurfaceErrors"#118

Merged
Kbhat1 merged 1 commit intomainfrom
RevertSurfaceErrors
Oct 8, 2025
Merged

Revert "Merge pull request #105 from sei-protocol/PebbleSurfaceErrors"#118
Kbhat1 merged 1 commit intomainfrom
RevertSurfaceErrors

Conversation

@Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Oct 8, 2025

This reverts commit de1d7fe, reversing changes made to 2533953.

Describe your changes and provide context

  • Revert surfacing errors from db layer since the rpc / keeper / store layer hard codes a lot of handling of record not found and there needs to be a larger refactor
  • Can re introduce this error after a redesign and consideration of impact

Testing performed to validate your change

  • Verified in unit tests and on node

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.78%. Comparing base (1641349) to head (53950e1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ss/test/storage_test_suite.go 0.00% 8 Missing ⚠️
ss/rocksdb/db.go 66.66% 1 Missing and 1 partial ⚠️
ss/pebbledb/db.go 83.33% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (45.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (39.78%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   39.76%   39.78%   +0.02%     
==========================================
  Files          58       58              
  Lines        7481     7477       -4     
==========================================
  Hits         2975     2975              
+ Misses       4160     4157       -3     
+ Partials      346      345       -1     
Files with missing lines Coverage Δ
ss/pebbledb/db.go 55.44% <83.33%> (-0.02%) ⬇️
ss/rocksdb/db.go 45.01% <66.66%> (+0.23%) ⬆️
ss/test/storage_test_suite.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kbhat1 Kbhat1 merged commit f369e78 into main Oct 8, 2025
7 of 9 checks passed
@Kbhat1 Kbhat1 deleted the RevertSurfaceErrors branch October 8, 2025 13:41
yzang2019 added a commit that referenced this pull request Oct 8, 2025
* main:
  Revert "Merge pull request #105 from sei-protocol/PebbleSurfaceErrors" (#118)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants