Backport release/v6.4: Fix upgrade list comparison to respect semver#3156
Merged
masih merged 1 commit intorelease/v6.4from Apr 1, 2026
Merged
Backport release/v6.4: Fix upgrade list comparison to respect semver#3156masih merged 1 commit intorelease/v6.4from
release/v6.4: Fix upgrade list comparison to respect semver#3156masih merged 1 commit intorelease/v6.4from
Conversation
Use semver to compare the upgrade names instead of alphanumeric order. Note that not all upgrade names have been a valid semver but the comparator used works. Tests are added to assert that it does. (cherry picked from commit 13c9966)
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v6.4 #3156 +/- ##
=============================================
Coverage 58.44% 58.44%
=============================================
Files 2090 2090
Lines 172338 172342 +4
=============================================
+ Hits 100717 100723 +6
+ Misses 62630 62629 -1
+ Partials 8991 8990 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
masih
approved these changes
Apr 1, 2026
sei-will
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3153 to
release/v6.4.