Fix upgrade list comparison to respect semver#3153
Merged
Conversation
Use semver to compare the upgrade names instead of alphanumeric order. Note that not all upgrade names have been a valid semver but the comparator used works. Tests are added to assert that it does.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3153 +/- ##
=======================================
Coverage 58.74% 58.74%
=======================================
Files 2095 2095
Lines 173533 173537 +4
=======================================
+ Hits 101935 101941 +6
+ Misses 62473 62472 -1
+ Partials 9125 9124 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sei-will
approved these changes
Mar 31, 2026
pompon0
approved these changes
Mar 31, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
Use semver to compare the upgrade names instead of alphanumeric order. Note that not all upgrade names have been a valid semver but the comparator used works. Tests are added to assert that it does. (cherry picked from commit 13c9966)
|
Successfully created backport PR for |
yzang2019
added a commit
that referenced
this pull request
Apr 1, 2026
* main: Make cryptosim state store backend configurable + No Op Wrapper + Read Disable Config (#3145) Add warning message for IAVL deprecation (#3159) Change default min valid per window to zero (#3157) support for starting autobahn from non-zero global block (#3136) Fix upgrade list comparison to respect semver (#3153)
yzang2019
added a commit
that referenced
this pull request
Apr 1, 2026
* main: plt-228 fixed static check on app and evmrpc package (#3154) flatkv cache (#3027) Make cryptosim state store backend configurable + No Op Wrapper + Read Disable Config (#3145) Add warning message for IAVL deprecation (#3159) Change default min valid per window to zero (#3157) support for starting autobahn from non-zero global block (#3136) Fix upgrade list comparison to respect semver (#3153)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use semver to compare the upgrade names instead of alphanumeric order.
Note that not all upgrade names have been a valid semver but the comparator used works. Tests are added to assert that it does.