Skip to content

Change default min valid per window to zero#3157

Merged
masih merged 2 commits intomainfrom
masih/fix-default-min-valid-per-window
Apr 1, 2026
Merged

Change default min valid per window to zero#3157
masih merged 2 commits intomainfrom
masih/fix-default-min-valid-per-window

Conversation

@masih
Copy link
Copy Markdown
Collaborator

@masih masih commented Apr 1, 2026

Considering Oracle Price Feeder is no longer with us, change the default minimum valid per window votes to zero in order to avoid long-lived localnets from halting if thy don't run price feeder

Considering Oracle Price Feeder is no longer with us, change the default
minimum valid per window votes to zero in order to avoid long-lived
localnets from halting if thy don't run price feeder
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 1, 2026, 1:55 PM

@masih masih enabled auto-merge April 1, 2026 13:22
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.73%. Comparing base (13c9966) to head (351f7f8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3157   +/-   ##
=======================================
  Coverage   58.73%   58.73%           
=======================================
  Files        2095     2095           
  Lines      173537   173537           
=======================================
  Hits       101933   101933           
  Misses      62475    62475           
  Partials     9129     9129           
Flag Coverage Δ
sei-chain-pr 80.32% <ø> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
x/oracle/types/params.go 62.61% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 08ac107 Apr 1, 2026
39 checks passed
@masih masih deleted the masih/fix-default-min-valid-per-window branch April 1, 2026 14:22
github-actions bot pushed a commit that referenced this pull request Apr 1, 2026
Considering Oracle Price Feeder is no longer with us, change the default
minimum valid per window votes to zero in order to avoid long-lived
localnets from halting if thy don't run price feeder

(cherry picked from commit 08ac107)
@seidroid
Copy link
Copy Markdown

seidroid bot commented Apr 1, 2026

Successfully created backport PR for release/v6.4:

yzang2019 added a commit that referenced this pull request Apr 1, 2026
* main:
  Make cryptosim state store backend configurable + No Op Wrapper + Read Disable Config (#3145)
  Add warning message for IAVL deprecation (#3159)
  Change default min valid per window to zero (#3157)
  support for starting autobahn from non-zero global block (#3136)
  Fix upgrade list comparison to respect semver (#3153)
yzang2019 added a commit that referenced this pull request Apr 1, 2026
* main:
  plt-228 fixed static check on app and evmrpc package (#3154)
  flatkv cache (#3027)
  Make cryptosim state store backend configurable + No Op Wrapper + Read Disable Config (#3145)
  Add warning message for IAVL deprecation (#3159)
  Change default min valid per window to zero (#3157)
  support for starting autobahn from non-zero global block (#3136)
  Fix upgrade list comparison to respect semver (#3153)
masih added a commit that referenced this pull request Apr 2, 2026
…3158)

Backport of #3157 to `release/v6.4`.

Co-authored-by: Masih H. Derkani <m@derkani.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants