Conversation
LCyson
commented
Jan 12, 2023
| dependency.ImmediateYoungerSibling = "" | ||
| found := false | ||
| for _, contractInfo := range allContractInfo { | ||
| if contractInfo.ContractAddr == newContract.ContractAddr { |
Contributor
Author
There was a problem hiding this comment.
this was not order agnostic previously @codchen and it updated the newContract to its dependency in a wrong order
codchen
reviewed
Jan 12, 2023
x/dex/types/keys.go
Outdated
| func ContractKeyPrefix(p string, contractAddr string) []byte { | ||
| return append([]byte(p), []byte(contractAddr)...) | ||
| address, _ := sdk.AccAddressFromBech32(contractAddr) | ||
| return append([]byte(p), address.Bytes()...) |
Collaborator
There was a problem hiding this comment.
cosmos SDK uses address.MustLengthPrefix to pad the bytes so we probably want to do the same too https://github.com/sei-protocol/sei-cosmos/blob/main/x/bank/types/key.go#L58
Contributor
Author
There was a problem hiding this comment.
think only bank module uses that, other modules use plain accAddress bytes: https://github.com/sei-protocol/sei-cosmos/blob/main/x/auth/types/keys.go#L30-L37
actually err: other modules use MustLengthPrefix, only the auth module uses the plain accAddress as the prefix, I'll change this to MustLengthPrefix in this case
added 3 commits
January 12, 2023 10:59
|
philipsu522
approved these changes
Jan 13, 2023
Contributor
philipsu522
left a comment
philipsu522
left a comment
There was a problem hiding this comment.
lgtm, thanks for this! Do you mind updating the title (i think there are typos)
| if err != nil { | ||
| return nil, err | ||
| } | ||
| creatorAddr, _ := sdk.AccAddressFromBech32(contract.Creator) |
Contributor
There was a problem hiding this comment.
should we still handle err?
Contributor
Author
There was a problem hiding this comment.
no we can assume the creatorAddr must be a valid bech32 address (as all msgserver has validated any request's address). This is also aligned with how other cosmos native modules convert bech32 address
codchen
approved these changes
Jan 13, 2023
LCyson
changed the title
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context This PR add latency and retries to occ scheduler log ## Testing performed to validate your change
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context This PR add latency and retries to occ scheduler log ## Testing performed to validate your change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Current x/dex module uses plain bech32 string instead of sdk.AccAddress bytes as the KVStore key, which is inconsistent with other cosmos native modules. This issue causes the parallelization access operators unable to identify dex module KVStore resource correctly and blocks users from defining the correct dex resource dependency.
This PR adds the following changes:
ValidateBasicin the message_ files to gate bech32 incompatible addressesTesting performed to validate your change
Unit test, e2e test
Next Steps
Discussed with @philipsu522 and @codchen, we would like to change all bech32 string used in any sei-chain custom module to sdk.AccAddress to be consistent: