Conversation
|
philipsu522
approved these changes
Jan 19, 2023
Contributor
philipsu522
left a comment
There was a problem hiding this comment.
lgtm, but let's get @codchen 's reviews as well.
in your local test, was vortex contract deployed with data on it (long book, orders...etc.)
Contributor
Author
Yes, tested by placing a LONG order and verified that order and also the trading pairs are nuked |
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
This reverts commit e2825c2. ## Describe your changes and provide context We disable cachekv events for `v0.3.xx+` versions because those are used in sei chain without allowing for parallelV1 concurrency due to its incompatibility with EVM ## Testing performed to validate your change
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
This reverts commit e2825c2. ## Describe your changes and provide context We disable cachekv events for `v0.3.xx+` versions because those are used in sei chain without allowing for parallelV1 concurrency due to its incompatibility with EVM ## Testing performed to validate your change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR adds a migration handler for the dex prefixes change here: #483. To be noted that here we will simply nuke the old data as this will only be needed on the devnet-2.
Other option is to replace the existing data like the snippet below, but given there are keys with suffix, either getting all pairs from contracts or assuming the contract address length is 62 in bytes is not as safe as nuking the old data on the devnet-2.
Testing performed to validate your change