Improve Peer Score Algorithm by blindchaser · Pull Request #248 · sei-protocol/sei-tendermint

blindchaser · 2024-10-28T13:22:44Z

The current peer score algorithm is not working effectively. Introducing a new peer score algorithm:

Added block sync performance reward: The score increases for every 5 consecutive successful block syncs.
Introduced time-decaying penalties for connection issues:
- The penalty for dial failures decreases over time, reducing its impact as time passes since the last failure.
- The penalty for disconnections decreases based on the time since the last connection, minimizing its impact with prolonged stability.
Maintained a score cap for non-block peers to ensure fair prioritization.

…i-tendermint into yiren/peer-score * 'yiren/peer-score' of https://github.com/sei-protocol/sei-tendermint: rever block sync logic

yzang2019 · 2024-10-29T17:39:49Z

internal/p2p/peermanager.go

-	MutableScore int64 // updated by router
+	MutableScore PeerScore // updated by router
+
+	ConsecSuccessfulBlocks int64


Maybe add another one called NumOfTimeouts?

the timeout will trigger the Disconnected() method which has counted to decrease score. the flow is:

timeout detection -> peer.didTimeout = true -> pool.removePeer(id, true) -> peerManager.Disconnected()

codecov · 2024-10-30T01:34:07Z

Codecov Report

Attention: Patch coverage is 72.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 58.18%. Comparing base (eab3712) to head (220ceec).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/p2p/peermanager.go	78.12%	5 Missing and 2 partials ⚠️
internal/state/execution.go	16.66%	4 Missing and 1 partial ⚠️
internal/blocksync/pool.go	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   58.22%   58.18%   -0.05%     
==========================================
  Files         249      249              
  Lines       34512    34549      +37     
==========================================
+ Hits        20094    20101       +7     
- Misses      12827    12856      +29     
- Partials     1591     1592       +1

Files with missing lines	Coverage Δ
internal/blocksync/reactor.go	`51.26% <100.00%> (+0.86%)`	⬆️
internal/blocksync/pool.go	`78.46% <33.33%> (-0.86%)`	⬇️
internal/state/execution.go	`61.83% <16.66%> (-0.46%)`	⬇️
internal/p2p/peermanager.go	`79.39% <78.12%> (+0.06%)`	⬆️

... and 19 files with indirect coverage changes

* feat: improve peer scoring algo * debug * debug * more debug * debug TryDiaNext * remove log * fix score type * rever block sync logic * rever block sync logic * rever block sync logic * Add block request log * Add apply block latency * add processEpeerEvent log back * update unit test * update unit test --------- Co-authored-by: yzang2019 <zymfrank@gmail.com>

* Reduce noisy tendermint logs * Suppress logs for all entering Use peermanager scores for blocksync peers and don't error out on block mismatch (#162) * Use peermanager scores for blocksync peers * Add debug * Randomize * debug * use state to filter * debug * debug * debug * debug * add comments * don't err * revert timeout * Add missing param * Remove flaky test * fix nil * debug * debug * debug * debug --------- Co-authored-by: Yiming Zang <50607998+yzang2019@users.noreply.github.com> Perf: Increase buffer size for pubsub server to boost performance (#167) * Increase buffer size for pubsub server * Add more timeout for test failure * Add more timeout * Fix test split scripts * Fix test split * Fix unit test * Unit test * Unit test [P2P] Optimize block pool requester retry and peer pick up logic (#170) * P2P Improvements: Fix block sync reactor and block pool retry logic Fix block sync auto restart not working as expected (#175) Fix edge case for blocksync (#178) Replay events during restart to avoid tx missing (#211) Add a new config to speed up block sync (#244) * Never switch to consensus due to timeout * Add blocksync peer config to speed up block sync rate * Fix config parsing * Add some logs feat: Exclude unconditional peers when connection limit checking (#245) Improve Peer Score Algorithm (#248) * feat: improve peer scoring algo * debug * debug * more debug * debug TryDiaNext * remove log * fix score type * rever block sync logic * rever block sync logic * rever block sync logic * Add block request log * Add apply block latency * add processEpeerEvent log back * update unit test * update unit test --------- Co-authored-by: yzang2019 <zymfrank@gmail.com>

* Reduce noisy tendermint logs * Suppress logs for all entering Use peermanager scores for blocksync peers and don't error out on block mismatch (#162) * Use peermanager scores for blocksync peers * Add debug * Randomize * debug * use state to filter * debug * debug * debug * debug * add comments * don't err * revert timeout * Add missing param * Remove flaky test * fix nil * debug * debug * debug * debug --------- Co-authored-by: Yiming Zang <50607998+yzang2019@users.noreply.github.com> Perf: Increase buffer size for pubsub server to boost performance (#167) * Increase buffer size for pubsub server * Add more timeout for test failure * Add more timeout * Fix test split scripts * Fix test split * Fix unit test * Unit test * Unit test [P2P] Optimize block pool requester retry and peer pick up logic (#170) * P2P Improvements: Fix block sync reactor and block pool retry logic Fix block sync auto restart not working as expected (#175) Fix edge case for blocksync (#178) Replay events during restart to avoid tx missing (#211) Add a new config to speed up block sync (#244) * Never switch to consensus due to timeout * Add blocksync peer config to speed up block sync rate * Fix config parsing * Add some logs feat: Exclude unconditional peers when connection limit checking (#245) Improve Peer Score Algorithm (#248) * feat: improve peer scoring algo * debug * debug * more debug * debug TryDiaNext * remove log * fix score type * rever block sync logic * rever block sync logic * rever block sync logic * Add block request log * Add apply block latency * add processEpeerEvent log back * update unit test * update unit test --------- Co-authored-by: yzang2019 <zymfrank@gmail.com> Add logs for blocksync Add log to debug replay Fix Fix setBlock true false Add more log for dialing Add more logs Add logs for missing height Fix Fix log Fix log Fix log Fix bpr pool goroutine Fix bpr pool goroutine Fix goroutine leak Fix goroutine leak

blindchaser added 6 commits October 20, 2024 20:41

feat: improve peer scoring algo

f8ca801

debug

8bb16d4

debug

ca529fa

more debug

ff5ff36

debug TryDiaNext

7371943

remove log

10b32a5

blindchaser requested a review from yzang2019 October 28, 2024 13:22

blindchaser changed the title ~~Yiren/peer score~~ Improve Peer Score Algorithm Oct 28, 2024

fix score type

e007e86

blindchaser force-pushed the yiren/peer-score branch from d80b3c9 to 9362881 Compare October 28, 2024 18:47

rever block sync logic

aa2f098

blindchaser force-pushed the yiren/peer-score branch from 9362881 to aa2f098 Compare October 28, 2024 18:49

rever block sync logic

9222988

blindchaser force-pushed the yiren/peer-score branch from aa2f098 to 9222988 Compare October 28, 2024 19:03

yzang2019 and others added 2 commits October 28, 2024 12:05

Merge branch 'yiren/peer-score' of https://github.com/sei-protocol/se…

e12c5b8

…i-tendermint into yiren/peer-score * 'yiren/peer-score' of https://github.com/sei-protocol/sei-tendermint: rever block sync logic

rever block sync logic

7ec96bf

blindchaser force-pushed the yiren/peer-score branch from 9222988 to 7ec96bf Compare October 28, 2024 19:08

yzang2019 and others added 6 commits October 28, 2024 12:13

Merge branch 'yiren/peer-score' of https://github.com/sei-protocol/se…

fa984f6

…i-tendermint into yiren/peer-score * 'yiren/peer-score' of https://github.com/sei-protocol/sei-tendermint: rever block sync logic

Add block request log

cef1905

Add apply block latency

9433ed4

add processEpeerEvent log back

e97b1f0

Merge branch 'main' into yiren/peer-score

e9fac17

update unit test

b5e8957

yzang2019 approved these changes Oct 29, 2024

View reviewed changes

yzang2019 reviewed Oct 29, 2024

View reviewed changes

update unit test

220ceec

blindchaser merged commit e9a22c9 into main Oct 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Peer Score Algorithm#248

Improve Peer Score Algorithm#248
blindchaser merged 18 commits intomainfrom
yiren/peer-score

blindchaser commented Oct 28, 2024 •

edited

Loading

Uh oh!

yzang2019 Oct 29, 2024

Uh oh!

blindchaser Oct 30, 2024

Uh oh!

codecov bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

blindchaser commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yzang2019 Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

blindchaser Oct 30, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

blindchaser commented Oct 28, 2024 •

edited

Loading

codecov bot commented Oct 30, 2024 •

edited

Loading