Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (65.57%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 57.21% 57.06% -0.16%
==========================================
Files 258 259 +1
Lines 34471 34483 +12
==========================================
- Hits 19723 19676 -47
- Misses 13169 13230 +61
+ Partials 1579 1577 -2
🚀 New features to boost your workflow:
|
| type errBadEncoding struct{ error } | ||
| type errBadChannel struct{ error } | ||
|
|
||
| const ( |
There was a problem hiding this comment.
Why do we remove those constants? It seems some of them are still valid defaults
There was a problem hiding this comment.
The constants are still there, just moved to relevant places. In particular, the defaults are inlined into the Default() method.
3 participants
untangled the MConnection internal logic.
Adjusted SpawnGlobal semantics accordingly.
I've shortened ping timeout to 10s.