Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Revert "refactor of MConnection internals"#324

Merged
pompon0 merged 1 commit intomainfrom
revert-322-gprusak-mconn
Sep 26, 2025
Merged

Revert "refactor of MConnection internals"#324
pompon0 merged 1 commit intomainfrom
revert-322-gprusak-mconn

Conversation

@pompon0
Copy link
Copy Markdown
Contributor

@pompon0 pompon0 commented Sep 26, 2025

Reverts #322

I've implemented some additional tests which indicate regression caused by this PR.
I don't know what is the issue exactly yet, but let's revert this PR for now.

@github-actions
Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 26, 2025, 1:52 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 80.30769% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.02%. Comparing base (a32efe0) to head (58490de).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/p2p/conn/connection.go 82.84% 41 Missing and 12 partials ⚠️
libs/utils/scope/global.go 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   56.97%   57.02%   +0.05%     
==========================================
  Files         259      258       -1     
  Lines       34483    34471      -12     
==========================================
+ Hits        19647    19658      +11     
+ Misses      13255    13227      -28     
- Partials     1581     1586       +5     
Files with missing lines Coverage Δ
internal/p2p/router.go 78.13% <100.00%> (+3.03%) ⬆️
internal/p2p/transport_memory.go 86.25% <100.00%> (+0.89%) ⬆️
libs/utils/proto.go 1.81% <ø> (+0.20%) ⬆️
libs/utils/wait.go 9.23% <ø> (+1.01%) ⬆️
libs/utils/scope/global.go 0.00% <0.00%> (ø)
internal/p2p/conn/connection.go 80.05% <82.84%> (-4.98%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pompon0 pompon0 enabled auto-merge (squash) September 26, 2025 14:00
@pompon0 pompon0 merged commit d3f4bd7 into main Sep 26, 2025
28 checks passed
@pompon0 pompon0 deleted the revert-322-gprusak-mconn branch September 26, 2025 14:05
pompon0 added a commit that referenced this pull request Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants