Skip to content

tendril: Add LossyDecoder::new_from_encoding_rs_decoder#704

Merged
jdm merged 2 commits into
servo:mainfrom
simonwuelker:tendril-decoder
Jan 9, 2026
Merged

tendril: Add LossyDecoder::new_from_encoding_rs_decoder#704
jdm merged 2 commits into
servo:mainfrom
simonwuelker:tendril-decoder

Conversation

@simonwuelker
Copy link
Copy Markdown
Member

@simonwuelker simonwuelker commented Jan 7, 2026 •
edited
Loading

After merging this change, the new version of tendril should be released.

@simonwuelker simonwuelker added the V-non-breaking A non-breaking change label Jan 7, 2026
@simonwuelker simonwuelker mentioned this pull request Jan 7, 2026
Merged
@nicoburns
Copy link
Copy Markdown
Contributor

nicoburns commented Jan 7, 2026

We should check for breaking changes before publishing. Last tendril release was 2022, and there were changes merged around the time that it was moved into this repo.

mrobinson
mrobinson approved these changes Jan 7, 2026
View reviewed changes
Comment thread tendril/src/stream.rs Outdated
@simonwuelker
Copy link
Copy Markdown
Member Author

simonwuelker commented Jan 8, 2026

We should check for breaking changes before publishing. Last tendril release was 2022, and there were changes merged around the time that it was moved into this repo.

I think upgrading to 2021 edition (#665) is already a breaking change so I'll bump tendril to 0.5

@simonwuelker simonwuelker force-pushed the tendril-decoder branch 2 times, most recently from 88a0f34 to 255e96f Compare January 8, 2026 11:59
@simonwuelker
Copy link
Copy Markdown
Member Author

simonwuelker commented Jan 8, 2026

servo/servo#41732 was approved so could someone with release permissions merge & publish this?

@simonwuelker
tendril: Add LossyDecoder::new_from_encoding_rs_decoder
4382a3d 
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@nicoburns
Copy link
Copy Markdown
Contributor

nicoburns commented Jan 8, 2026

We should check for breaking changes before publishing. Last tendril release was 2022, and there were changes merged around the time that it was moved into this repo.

I think upgrading to 2021 edition (#665) is already a breaking change so I'll bump tendril to 0.5

Yeah, and tendril is not that widely used (almost everyone is using it as a dependency of html5ever) so publishing breaking versions isn't too big of a deal anyway.

@simonwuelker simonwuelker mentioned this pull request Jan 8, 2026
Merged
@jdm
Merge branch 'main' into tendril-decoder
4ddc2e4 
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm jdm enabled auto-merge January 9, 2026 04:36
@jdm jdm added this pull request to the merge queue Jan 9, 2026
Merged via the queue into servo:main with commit d8e3e0c Jan 9, 2026
8 checks passed
@jdm
Copy link
Copy Markdown
Member

jdm commented Jan 9, 2026

Published.

@simonwuelker simonwuelker mentioned this pull request Jan 10, 2026
Merged
github-merge-queue Bot pushed a commit to servo/servo that referenced this pull request Jan 22, 2026
@simonwuelker
script: Don't let LossyDecoder handle the BOM (#41732)
9ab2c7c 
We already handle BOMs when detecting the encoding. The decoder itself
should not touch the BOMs in any way.

Depends on servo/html5ever#704

Testing: New tests start to pass

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
github-merge-queue Bot pushed a commit to servo/servo that referenced this pull request Jan 23, 2026
@simonwuelker
script: Don't let LossyDecoder handle the BOM (#41732)
6f3c364 
We already handle BOMs when detecting the encoding. The decoder itself
should not touch the BOMs in any way.

Depends on servo/html5ever#704

Testing: New tests start to pass

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
github-merge-queue Bot pushed a commit to servo/servo that referenced this pull request Jan 23, 2026
@simonwuelker
script: Don't let LossyDecoder handle the BOM (#41732)
80555eb 
We already handle BOMs when detecting the encoding. The decoder itself
should not touch the BOMs in any way.

Depends on servo/html5ever#704

Testing: New tests start to pass

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrobinson mrobinson mrobinson approved these changes

@jdm jdm jdm approved these changes

@nicoburns nicoburns nicoburns approved these changes

Assignees

No one assigned

Labels

V-non-breaking A non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simonwuelker @nicoburns @jdm @mrobinson