tendril: Remove integration with the encoding crate#705
Merged
Conversation
nicoburns
added
dependencies
simonwuelker
approved these changes
Jan 8, 2026
Member
simonwuelker
left a comment
simonwuelker
left a comment
There was a problem hiding this comment.
Nice, let's merge this before #704
The encoding crate is abandoned and it's functionality is covered by the actively maintained encoding_rs crate.
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
remove-tendril-encoding
branch
from
6ccd31e to
163ff9c
Compare
mrobinson
approved these changes
Jan 8, 2026
mrobinson
changed the title
encoding crateencoding crate
nicoburns
commented
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
encodingcrate (https://lib.rs/crates/encoding) is unmaintained (last update ~10 years ago) and it's functionality has already been replaced by theencoding_rscrate (https://lib.rs/crates/encoding_rs) which already has an integration in Tendril which we are using in Servo.