Fixes related to use of forked PID #1305
Conversation
|
@alejandro-colomar Modified and added in separate PR as requested. |
|
Please use one space after period in the commit message. That would help readability of it. |
Karlson2k
changed the title
16 hours ago you asked to correct commit messages to use two spaces after period.
Please choose one of the two. |
Signed-off-by: Evgeny Grin (Karlson2k) <k2k@drgrin.dev>
Oops, I meant to write here "two" too. My brain was probably thinking of "don't use one" and ended up writing something with a one. :)
Please use two spaces after period. |
Signed-off-by: Evgeny Grin (Karlson2k) <k2k@drgrin.dev>
The correct utmp update functionality was broken mainly by commit 91fc513, which moved update of utmp after forking (when PAM is used). It was also misinterpretation of GNU/Linux utmp specifications, where is specified that ut_pid must be the PID of the **login** process (not a PID of any forked process). Wrong ut_pid also prevents utmp cleanup, which performed by init process and should clean entry with the same ut_pid as started login process. GNU/Linux description of utmp updates can be found at the next url: https://man7.org/linux/man-pages/man5/utmp.5.html Signed-off-by: Evgeny Grin (Karlson2k) <k2k@drgrin.dev>
When PAM is not used, login does not fork itself so its own PID should be checked instead of parent PID. Fixes: b44a6c3 (26-12-2007; "If started as init, login and sulogin need to start a new session.") Signed-off-by: Evgeny Grin (Karlson2k) <k2k@drgrin.dev>
Karlson2k
force-pushed
the
fork-fix-partial
branch
from
bd38b29 to
8bfe1c9
Compare
|
Updated as requested (except this comment). |
alejandro-colomar
left a comment
alejandro-colomar
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
Reviewed-by: Alejandro Colomar <alx@kernel.org>
I'll merge now, but CC: @hallyn in case he has any comments.
2 participants
Number of fixes around using PID of forked or parent process.
A subset of commits from #1292, as requested here.