Refactor utmp entry search #1306
Conversation
lib/utmp.c
Outdated
| { | ||
| struct utmpx *ut; | ||
| struct utmpx *ret = NULL; | ||
| struct utmpx *ut; |
There was a problem hiding this comment.
Please keep the two spaces after the base type.
There was a problem hiding this comment.
Please use two spaces after the base type.
Never saw such requirements.
Could you be specific?
When two spaces after base type should be used in variables definitions?
When point is used?
When base type is aggregate?
When both (pointer to an aggregate type)?
There was a problem hiding this comment.
I inherited those rules from NGINX Unit, which itself has rules similar to NGINX.
The NGINX rules are documented here: https://nginx.org/en/docs/dev/development_guide.html#code_style
(Search for 'Variables'.)
The difference in the NGINX Unit project (and shadow) is that the * is aligned as if it were part of the name
There was a problem hiding this comment.
It would be nice to copy at least this short explanation to some file/document.
There was a problem hiding this comment.
Yup, eventually.
Signed-off-by: Evgeny Grin (Karlson2k) <k2k@drgrin.dev>
Signed-off-by: Evgeny Grin (Karlson2k) <k2k@drgrin.dev>
Karlson2k
force-pushed
the
refactor-utmp-search
branch
from
7b44c8d to
ea98f35
Compare
|
Merged as part of #1305 |
2 participants
Readability improvements only, without functional changes.
A subset from #1305
@alejandro-colomar