Skip to content

update: v13#29

Merged
edivalentinitu merged 1 commit intomainfrom
v13
May 15, 2025
Merged

update: v13#29
edivalentinitu merged 1 commit intomainfrom
v13

Conversation

@edivalentinitu
Copy link
Contributor

@edivalentinitu edivalentinitu commented Apr 30, 2025

  • update dependencies in pyproject.toml to invenio-app-rdm v13
  • specify invenio-override extension in pyproject.toml
  • fix Dockerfiles: move to pnpm, add specific ENV for invenio assets
  • remove Pipfiles
  • add CHANGE.md
  • add migrations directoy
  • updated uv.lock

@edivalentinitu edivalentinitu marked this pull request as draft April 30, 2025 10:45
@edivalentinitu edivalentinitu force-pushed the v13 branch 3 times, most recently from 4440704 to 5864854 Compare May 7, 2025 11:52
@edivalentinitu edivalentinitu linked an issue May 7, 2025 that may be closed by this pull request
Closed
@mb-wali
Copy link
Contributor

mb-wali commented May 8, 2025

WARNING in factory: APP_ALLOWED_HOSTS is deprecated and has been replaced by TRUSTED_HOSTS.

Please change APP_ALLOWED_HOSTS to TRUSTED_HOSTS in this repo.

@edivalentinitu edivalentinitu force-pushed the v13 branch 3 times, most recently from ad1d78b to 37fa561 Compare May 13, 2025 08:04
@edivalentinitu edivalentinitu linked an issue May 13, 2025 that may be closed by this pull request
@edivalentinitu edivalentinitu force-pushed the v13 branch 2 times, most recently from 9dad811 to aa2f1e3 Compare May 15, 2025 08:26
@edivalentinitu edivalentinitu marked this pull request as ready for review May 15, 2025 08:38
CHANGES.md Outdated
- dockerfiles: changed npm to pnpm, added environment variable for invenio-assets
- actions: install invenio-override with preferred branch

Version 0.0.1 (released 2025-02-10)
Copy link
Contributor

@mb-wali mb-wali May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Version 0.0.1 (released 2025-02-10)
Version 0.12.0 (released 2025-02-10)

CHANGES.md Outdated
Changes
=======

Version <next>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Version <next>
Version 0.13.0

UV-GUIDE.md Outdated
@@ -1,5 +1,6 @@
## **Working with UV InvenioRDM**

### Instance now running with invenio-app-rdm v13 which has UV already integrated. The following guide however is still helpful for a better understanding of how UV works.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Instance now running with invenio-app-rdm v13 which has UV already integrated. The following guide however is still helpful for a better understanding of how UV works.

invenio alembic upgrade
```

this has to be done to add maybe other small changes to the database too
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you had some issue with the database running invenio alembic upgrade - add that step as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already added in the first steps of Data Migration section

@lpandath
Copy link
Contributor

lpandath commented May 15, 2025

great work!

It works perfectly during testing. The only thing while rebulding the indexes and database for global search I get warnings:
Screenshot From 2025-05-15 10-59-54

@edivalentinitu
Copy link
Contributor Author

great work!

It works perfectly during testing. The only thing while rebulding the indexes and database for global search I get warnings: Screenshot From 2025-05-15 10-59-54

as far as I understand, these warnings are expected and not related to the updates in this PR or from invenio-override. those indexes are created "on the fly" and could be missing at the first runs.

@lpandath
Copy link
Contributor

lpandath commented May 15, 2025

as far as I understand, these warnings are expected and not related to the updates in this PR or from invenio-override. those indexes are created "on the fly" and could be missing at the first runs.

Sure, but since they're included in our pyproject.toml file as dependencies, shouldn't building them be part of the process?

Either way, we can create separate issue or clarify.
Approved from my side.

Copy link
Contributor

@mb-wali mb-wali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

[tool.uv.sources]
invenio-override = { git = "https://github.com/sharedRDM/invenio-override", branch = "main" }
#invenio-override = { path = "/Users/lpandath/Documents/work/rdm/invenio/invenio-instances/invenio-version-9/invenio-override", editable=true }
#invenio-override = { path = "/home/eduard/Schreibtisch/invenio-override", editable=true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note - this is okay for now but should remove this once you have a release from instance v0.13.0.

@edivalentinitu edivalentinitu merged commit 5ad4c8b into main May 15, 2025
@lpandath lpandath deleted the v13 branch May 19, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

changelogs v13

3 participants