-
Notifications
You must be signed in to change notification settings - Fork 1
update: v13 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
update: v13 #29
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| Changes | ||
| ======= | ||
|
|
||
| Version 0.13.0 | ||
|
|
||
| - config: new variables for invenio-app-rdm v13 in invenio.cfg, update nginx.conf | ||
| - uv: update uv.lock with newest versions supported by invenio-app-rdm v13 | ||
| - pipfiles: deleted | ||
| - dockerfiles: changed npm to pnpm, added environment variable for invenio-assets | ||
| - actions: install invenio-override with preferred branch | ||
|
|
||
| Version 0.12.0 (released 2025-02-10) | ||
|
|
||
| - initial release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| # Migrate from v12 to v13 | ||
|
|
||
| ## set env variables | ||
|
|
||
| ```bash | ||
| RDM_USER_MODERATION_ENABLED = True | ||
| """User moderation feature enabled.""" | ||
|
|
||
| RDM_SEARCH_SORT_BY_VERIFIED = True | ||
| """Enable the sorting of records by verified.""" | ||
|
|
||
| USERS_RESOURCES_ADMINISTRATION_ENABLED = True | ||
| """Enable user administration.""" | ||
|
|
||
| USERS_RESOURCES_GROUPS_ENABLED = True | ||
| """Config to enable features related to existence of groups.""" | ||
|
|
||
| COMMUNITIES_ADMINISTRATION_DISABLED = False # this enables it | ||
| """Enable communities administration.""" | ||
|
|
||
| APP_RDM_SUBCOMMUNITIES_LABEL = "Projects" | ||
| """Label for subcommunities in communities browse page.""" | ||
|
|
||
| COMMUNITIES_SHOW_BROWSE_MENU_ENTRY = True | ||
| """Toggle to show or hide the 'Browse' menu entry for communities.""" | ||
|
|
||
| JOBS_ADMINISTRATION_ENABLED = True | ||
| """Enable Jobs administration view.""" | ||
| ``` | ||
|
|
||
| ## update env variables | ||
|
|
||
| - change from `APP_ALLOWED_HOSTS` to `TRUSTED_HOSTS` due flask >= 3 | ||
|
|
||
| ## Update Services | ||
|
|
||
|
|
||
| ### Configuration change for nginx | ||
|
|
||
|
|
||
| The new PDF file previewer is based on pdfjs-dist v4, which uses ECMAScript | ||
| modules (.mjs) over CommonJS files (.js). These files are not registered in the | ||
| default configuration for nginx. This can result in the MIME type being reported | ||
| incorrectly, and thus being blocked by the browser, leading to a broken PDF | ||
| preview. | ||
|
|
||
| Luckily, this can be simply fixed by adding a custom types entry; e.g. in the | ||
| http block in nginx.conf (cf. this Cookiecutter PR). | ||
|
|
||
| ``` | ||
| include /etc/nginx/mime.types; | ||
| default_type application/octet-stream; | ||
| types { | ||
| # Tell nginx that ECMAScript modules are also JS | ||
| application/javascript js mjs; | ||
| } | ||
| ``` | ||
|
|
||
| ## Data Migration | ||
|
|
||
| Because the new instance version will no longer mandatory depend on invenio-records-lom and invenio-records-marc21, some errors can appear when trying to run the database migration. The steps to resolve these are the following: | ||
|
|
||
| 1. Login/enter the environment where the instance is deployed. | ||
| 2. Access the database and run ```select * from alembic_version```. | ||
| 3. In the invenio-records-lom and invenio-records-marc21 look for revisions id that are found in the results of the query at the second step. | ||
| 4. Delete the migrations you do not need. | ||
|
|
||
| After that you can run the following commands: | ||
|
|
||
| ```bash | ||
| invenio db create | ||
| ``` | ||
|
|
||
| run this to create any new table | ||
|
|
||
| ```bash | ||
| invenio alembic upgrade | ||
| ``` | ||
|
|
||
| this has to be done to add maybe other small changes to the database too | ||
|
|
||
|
|
||
| # reindex | ||
|
|
||
| ``` | ||
| invenio rdm rebuild-all-indices | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,20 +9,19 @@ authors = [ | |
| ] | ||
|
|
||
| dependencies = [ | ||
| "invenio-app-rdm[opensearch2] ~=12.0.0", | ||
| "invenio-assets >=3.1.0,<3.2.0", | ||
| "invenio-logging[sentry_sdk] ~=2.0", | ||
| "invenio-app-rdm[opensearch2] ~=13.0.0b3.dev2", | ||
| "invenio-logging[sentry_sdk]>=4.0.0,<5.0.0", | ||
| "uwsgi >=2.0", | ||
| "uwsgitop >=0.11", | ||
| "uwsgi-tools >=1.1.1", | ||
| "invenio-override ~=0.0.3" | ||
| "invenio-override[marc21] ~=0.0.4", | ||
| ] | ||
|
|
||
| [tool.setuptools] | ||
| py-modules = [] | ||
|
|
||
| [tool.uv.sources] | ||
| invenio-override = { git = "https://github.com/sharedRDM/invenio-override", branch = "main" } | ||
| #invenio-override = { path = "/Users/lpandath/Documents/work/rdm/invenio/invenio-instances/invenio-version-9/invenio-override", editable=true } | ||
| #invenio-override = { path = "/home/eduard/Schreibtisch/invenio-override", editable=true } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note - this is okay for now but should remove this once you have a release from instance v0.13.0. |
||
| #invenio-cli = { git = "https://github.com/utnapischtim/invenio-cli", branch = "move-to-uv-instead-of-pip" } | ||
| #invenio-theme-tugraz = { git = "https://github.com/tu-graz-library/invenio-theme-tugraz", branch = "master" } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you had some issue with the database running
invenio alembic upgrade- add that step as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already added in the first steps of Data Migration section