Skip to content

feat: choose from more dockerfiles#38

Merged
edivalentinitu merged 1 commit intomainfrom
update-deploy
Jun 5, 2025
Merged

feat: choose from more dockerfiles#38
edivalentinitu merged 1 commit intomainfrom
update-deploy

Conversation

@edivalentinitu
Copy link
Contributor

@edivalentinitu edivalentinitu commented Jun 3, 2025 •
edited
Loading

  • add Dockerfile.oer and Dockerfile.basic
  • build 3 new images: oer, basic, vanilla
  • remove theme image build
  • add gh action option to choose which image to deploy
  • add gh action option to force recreation of instance
  • don't install invenio-override when pushing on tags
  • update README

@edivalentinitu edivalentinitu force-pushed the update-deploy branch 17 times, most recently from 858ab07 to 75f0c9e Compare June 5, 2025 08:58
@edivalentinitu edivalentinitu requested a review from mb-wali June 5, 2025 09:00
@edivalentinitu edivalentinitu marked this pull request as ready for review June 5, 2025 09:01
@edivalentinitu edivalentinitu linked an issue Jun 5, 2025 that may be closed by this pull request
docker: images #31
Closed
mb-wali
mb-wali reviewed Jun 5, 2025
View reviewed changes
mb-wali
mb-wali reviewed Jun 5, 2025
View reviewed changes
@edivalentinitu edivalentinitu force-pushed the update-deploy branch 2 times, most recently from 7e6b3c2 to 3f3c811 Compare June 5, 2025 09:18
mb-wali
mb-wali approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@mb-wali mb-wali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the README - add for each variant of images a description:
e.g. vanila = invenioRDM base image without invenio-override. and so on..

@edivalentinitu edivalentinitu force-pushed the update-deploy branch 3 times, most recently from 4c4605f to 97e0d53 Compare June 5, 2025 10:26
@edivalentinitu edivalentinitu merged commit 1118555 into main Jun 5, 2025
@edivalentinitu edivalentinitu deleted the update-deploy branch June 12, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mb-wali mb-wali mb-wali approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docker: images

2 participants

@edivalentinitu @mb-wali