Merged
Conversation
bananabot9000
approved these changes
Apr 1, 2026
Collaborator
bananabot9000
left a comment
There was a problem hiding this comment.
Pre-computing line segments on append to avoid re-running Intl.Segmenter on resize -- smart trade-off of memory for speed. The width-1 bulk slice optimisation is the real win: ASCII lines (vast majority of terminal output) become arithmetic-only on re-wrap.
One note for the future: lineSegments array grows with displayBuffer. If display buffer ever gets trimmed/rotated, segments need to stay in sync. Not a blocker -- just worth a comment.
10K lines from ~10ms to <2ms. Clean perf test with CI-aware thresholds.
LGTM 🍌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #166