Skip to content

fix: assert localhost when server address doesnt match. fixes #131 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shellscape merged 1 commit into from
May 4, 2019
Merged

fix: assert localhost when server address doesnt match. fixes #131 #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,16 @@ const start = async function start() {

address.hostname = address.address;

// fix #131 - server address reported as 127.0.0.1 for localhost
if (address.hostname !== this.options.host && this.options.host === 'localhost') {
address.hostname = this.options.host;
}

// we set this so the client can use the actual hostname of the server. sometimes the net
// will mutate the actual hostname value (e.g. :: -> [::])
this.options.address = url.format(address);

const uri = `${protocol}://${url.format(this.options.address)}`;
const uri = `${protocol}://${this.options.address}`;

this.log.info('Server Listening on:', uri);

Expand Down