fix: assert localhost when server address doesnt match. fixes #131#132
Merged
shellscape merged 1 commit intomasterfrom May 4, 2019
Merged
fix: assert localhost when server address doesnt match. fixes #131#132shellscape merged 1 commit intomasterfrom
shellscape merged 1 commit intomasterfrom
Conversation
matheus1lva
approved these changes
May 3, 2019
smashercosmo
pushed a commit
to smashercosmo/webpack-plugin-serve
that referenced
this pull request
Jul 23, 2019
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
There is potential for breakage if users were performing checks to work around this issue, or were expecting the incorrect address in an event hook.
Please Describe Your Changes
#131 outlines a problem whereby
localhostis rewritten to127.0.0.1after the server has been started and reports the address. That address is used to construct the URI for both console output and theopenfeature. In the referenced issue's case, a whitelist was being used and127.0.0.1was not on that list. The mismatch was unexpected.This commit catches that discrepancy and rewrites the hostname portion of the url data to
localhost.