fix(server): remove localhost check for address#240
Closed
bhanufyi wants to merge 1 commit intoshellscape:masterfrom
Closed
fix(server): remove localhost check for address#240bhanufyi wants to merge 1 commit intoshellscape:masterfrom
bhanufyi wants to merge 1 commit intoshellscape:masterfrom
Conversation
Owner
|
I'm currently away on vacation and will check this and the associated issue when back. |
Author
|
Hi @shellscape 😄, can you please have a look at this issue when you get some free time |
Owner
|
@bhanuprasadcherukuvada are you still using the project? |
Author
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
This is PR is related to an issue #239
when using custom domain which is proxied to 127.0.0.1 as host in options
In the logs it shows that Server is started at http://127.0.0.1:port instead of domain name.
An explicit check was added for localhost at #132 but this check doesn't allow the use of custom domain names