Create a subprocess for uploading the report as it goes#533
Open
Create a subprocess for uploading the report as it goes#533
Conversation
…vents that, when used, defer calls to Sift to the end of the test where the log is then replayed and uploaded.
| os.dup2(saved_stderr, 2) | ||
| os.close(saved_stderr) | ||
| else: | ||
| self._replay_proc = None |
Collaborator
There was a problem hiding this comment.
define this at the class level to make it a bit easier to follow (right now it is just defined/set in this function)
| simulated_steps_order: list[str] = [] | ||
| simulated_measurements_by_id: dict[str, TestMeasurement] = {} | ||
| simulated_measurements_order: list[str] = [] | ||
| if incremental: |
Collaborator
There was a problem hiding this comment.
Perhaps a bit more error handling?
Any thoughts on how to handle partial writes/killed processes and replaying from those?
jsonl is a good call since at least each line is independent (vs. I've seen json logs/dbs get corrupted very easily) so should be fairly isolated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.