Skip to content

Create a subprocess for uploading the report as it goes #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ian-sift wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Create a subprocess for uploading the report as it goes #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
849d2da
python(feat): Add optional logging of test result create and update e…
ian-sift Apr 8, 2026
5c5170c
add a script for replaying log if it failed. also don't clean up log …
ian-sift Apr 9, 2026
345f907
Error reporting cleanup
ian-sift Apr 9, 2026
d44cef0
fmt
ian-sift Apr 9, 2026
1dcd64f
Rename grpc dir so it doesn't shadow grpc package
ian-sift Apr 9, 2026
e5c8710
lint
ian-sift Apr 9, 2026
6ac259b
lint
ian-sift Apr 9, 2026
5c4beb2
mypy
ian-sift Apr 9, 2026
ab62b5d
rm test error
ian-sift Apr 9, 2026
0e5693c
Create a subprocess for uploading the report as it goes
ian-sift Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ib/sift_client/_internal/grpc/__init__.py → ...ient/_internal/grpc_transport/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Example of establishing a connection to Sift's gRPC APi:

```python
from sift_client._internal.grpc.transport import SiftChannelConfig, use_sift_channel
from sift_client._internal.grpc_transport.transport import SiftChannelConfig, use_sift_channel

# Be sure not to include the url scheme i.e. 'https://' in the uri.
sift_channel_config = SiftChannelConfig(uri=SIFT_BASE_URI, apikey=SIFT_API_KEY)
Expand Down
0 ...rnal/grpc/_async_interceptors/__init__.py → ...transport/_async_interceptors/__init__.py
View file
Open in desktop
File renamed without changes.
0 ...internal/grpc/_async_interceptors/base.py → ...rpc_transport/_async_interceptors/base.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...rnal/grpc/_async_interceptors/metadata.py → ...transport/_async_interceptors/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from grpc import aio as grpc_aio

from sift_client._internal.grpc._async_interceptors.base import ClientAsyncInterceptor
from sift_client._internal.grpc_transport._async_interceptors.base import ClientAsyncInterceptor

Metadata = List[Tuple[str, str]]

Expand Down
0 .../_internal/grpc/_interceptors/__init__.py → .../grpc_transport/_interceptors/__init__.py
View file
Open in desktop
File renamed without changes.
0 ...ient/_internal/grpc/_interceptors/base.py → ...rnal/grpc_transport/_interceptors/base.py
View file
Open in desktop
File renamed without changes.
0 ...t/_internal/grpc/_interceptors/context.py → ...l/grpc_transport/_interceptors/context.py
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions .../_internal/grpc/_interceptors/metadata.py → .../grpc_transport/_interceptors/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

import grpc

from sift_client._internal.grpc._interceptors.base import ClientInterceptor, Continuation
from sift_client._internal.grpc._interceptors.context import ClientCallDetails
from sift_client._internal.grpc_transport._interceptors.base import ClientInterceptor, Continuation
from sift_client._internal.grpc_transport._interceptors.context import ClientCallDetails

Metadata = List[Tuple[str, str]]

Expand Down
0 .../lib/sift_client/_internal/grpc/_retry.py → ...client/_internal/grpc_transport/_retry.py
View file
Open in desktop
File renamed without changes.
0 ...b/sift_client/_internal/grpc/keepalive.py → ...ent/_internal/grpc_transport/keepalive.py
View file
Open in desktop
File renamed without changes.
0 ...rnal/grpc/server_interceptors/__init__.py → ...transport/server_interceptors/__init__.py
View file
Open in desktop
File renamed without changes.
0 ...server_interceptors/server_interceptor.py → ...server_interceptors/server_interceptor.py
View file
Open in desktop
File renamed without changes.
17 changes: 11 additions & 6 deletions ...b/sift_client/_internal/grpc/transport.py → ...ent/_internal/grpc_transport/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,19 @@
import grpc.aio as grpc_aio
from typing_extensions import NotRequired, TypeAlias

from sift_client._internal.grpc._async_interceptors.metadata import MetadataAsyncInterceptor
from sift_client._internal.grpc._interceptors.metadata import Metadata, MetadataInterceptor
from sift_client._internal.grpc_transport._async_interceptors.metadata import (
MetadataAsyncInterceptor,
)
from sift_client._internal.grpc_transport._interceptors.metadata import (
Metadata,
MetadataInterceptor,
)

if TYPE_CHECKING:
from sift_client._internal.grpc._async_interceptors.base import ClientAsyncInterceptor
from sift_client._internal.grpc._interceptors.base import ClientInterceptor
from sift_client._internal.grpc._retry import RetryPolicy
from sift_client._internal.grpc.keepalive import DEFAULT_KEEPALIVE_CONFIG, KeepaliveConfig
from sift_client._internal.grpc_transport._async_interceptors.base import ClientAsyncInterceptor
from sift_client._internal.grpc_transport._interceptors.base import ClientInterceptor
from sift_client._internal.grpc_transport._retry import RetryPolicy
from sift_client._internal.grpc_transport.keepalive import DEFAULT_KEEPALIVE_CONFIG, KeepaliveConfig

SiftChannel: TypeAlias = grpc.Channel
SiftAsyncChannel: TypeAlias = grpc_aio.Channel
Expand Down
6 changes: 4 additions & 2 deletions ...t_client/_internal/grpc/transport_test.py → ...internal/grpc_transport/transport_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@
add_DataServiceServicer_to_server,
)

from sift_client._internal.grpc.server_interceptors.server_interceptor import ServerInterceptor
from sift_client._internal.grpc.transport import SiftChannelConfig, use_sift_channel
from sift_client._internal.grpc_transport.server_interceptors.server_interceptor import (
ServerInterceptor,
)
from sift_client._internal.grpc_transport.transport import SiftChannelConfig, use_sift_channel


class DataService(DataServiceServicer):
Expand Down
Loading
Loading