Prevent contact number NPE

[cascheberg]

Contributor checklist

• I am following the Code Style Guidelines
• I have tested my contribution
• My contribution is fully baked and ready to be merged as is
• I have made the choice whether I want the BitHub reward or not by omitting or adding the word FREEBIE in my commit message

---

Description

I can't reproduce the crash in #5454, but this should fix it: if the returned contact phone number is null, fall through to return default RecipientDetails.
It's still not clear to me which result is actually returned.
I have some "numberless" SMS in my stock messaging app, and there I can't even add the sender to my contacts.

//FREEBIE

[glems2]

@cascheberg Great, thank you for the fix!
Any idea on who might merge this and when? Or what might be in the way of doing so?
I'm currently up in the air about Signal.

[siloportem]

Got also an SMS that caused the crash described in #5454, this fixes it for me. After compiling my own Signal apk with this patch applied, I am able to access all my messages again including the SMS that caused the crash. Thank you, hope this will be merged into the main-branch soon.

[edent]

Is there any way I can apply this to an existing installation? My messages are trapped due to #5454 :-(

Or, any details on when this will be merged & released?

[2-4601]

If you have compiled Signal yourself or you have root you can do that. But it's better to ask help for those at https://whispersystems.discoursehosting.net/

[smarek]

Thank you, I now did verify, this PR is correct solution for problems discussed in #5454