-
-
Notifications
You must be signed in to change notification settings - Fork 17
Fix starting element error when analyzing corpora #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 72.19% 72.20%
=======================================
Files 414 414
Lines 35144 35154 +10
Branches 4862 4865 +3
=======================================
+ Hits 25373 25383 +10
Misses 8679 8679
Partials 1092 1092 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @ddaspit)
src/SIL.Machine/PunctuationAnalysis/QuotationMarkFinder.cs line 50 at r1 (raw file):
.Select(m => { int[] textElementBeginnings = StringInfo.ParseCombiningCharacters(textSegment.Text);
This could be made more efficient, but I'm not sure how much of a difference it'd really make.
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a unit test to cover this case?
@ddaspit reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
Enkidu93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @ddaspit)
src/SIL.Machine/PunctuationAnalysis/QuotationMarkFinder.cs line 50 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
This could be made more efficient, but I'm not sure how much of a difference it'd really make.
I just went ahead and did it.
…nual test for running quote convention analysis
1045f29 to
36ec6b6
Compare
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
Fixes #324
This change is