Use text element indices not string indices for PreviousCharacter #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 72.20% 72.22% +0.01%
==========================================
Files 414 414
Lines 35154 35154
Branches 4865 4865
==========================================
+ Hits 25383 25389 +6
+ Misses 8679 8674 -5
+ Partials 1092 1091 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
approved these changes
Aug 28, 2025
Contributor
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the recent text element issue @pmachapman was seeing. (Is there an issue for that, Peter? I couldn't find it). Also, adds a test to cover it.
Related to #324.
This change is