Skip to content

Conversation

@emteknetnz
Copy link
Member

Issue #762

@emteknetnz emteknetnz mentioned this pull request Jun 16, 2025
2 tasks
@emteknetnz emteknetnz force-pushed the pulls/6.0/writing-style branch 6 times, most recently from e5c6691 to 1a6b04d Compare June 17, 2025 00:34
@emteknetnz emteknetnz marked this pull request as ready for review June 17, 2025 01:20
@emteknetnz emteknetnz force-pushed the pulls/6.0/writing-style branch 3 times, most recently from 14eafe1 to ef19c68 Compare June 18, 2025 03:54
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a comment in #766 (comment) before formally starting the review

@emteknetnz emteknetnz force-pushed the pulls/6.0/writing-style branch from ef19c68 to 888df7e Compare June 18, 2025 05:18
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Michal's suggested change to go

@emteknetnz emteknetnz force-pushed the pulls/6.0/writing-style branch from 888df7e to 77eae3f Compare June 18, 2025 21:59
@GuySartorelli GuySartorelli merged commit 7b13e40 into silverstripe:6.0 Jun 18, 2025
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/writing-style branch June 18, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants