-
Notifications
You must be signed in to change notification settings - Fork 73
DOC Tidy up writing style of performance section #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GuySartorelli
merged 1 commit into
silverstripe:6.0
from
creative-commoners:pulls/6.0/writing-style
Jun 18, 2025
Merged
DOC Tidy up writing style of performance section #766
GuySartorelli
merged 1 commit into
silverstripe:6.0
from
creative-commoners:pulls/6.0/writing-style
Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
e5c6691 to
1a6b04d
Compare
GuySartorelli
requested changes
Jun 17, 2025
en/02_Developer_Guides/08_Performance/00_Partial_Template_Caching.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/00_Partial_Template_Caching.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/00_Partial_Template_Caching.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/00_Partial_Template_Caching.md
Outdated
Show resolved
Hide resolved
en/02_Developer_Guides/08_Performance/00_Partial_Template_Caching.md
Outdated
Show resolved
Hide resolved
14eafe1 to
ef19c68
Compare
GuySartorelli
requested changes
Jun 18, 2025
Member
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a comment in #766 (comment) before formally starting the review
en/02_Developer_Guides/08_Performance/09_Other_Optimisations.md
Outdated
Show resolved
Hide resolved
ef19c68 to
888df7e
Compare
GuySartorelli
requested changes
Jun 18, 2025
Member
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just Michal's suggested change to go
888df7e to
77eae3f
Compare
GuySartorelli
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #762