Exit with code only if it's Numeric > 0

[mszyndel]

Fixes bug (#281) causing simplecov to sometimes return 0 despite tests failing

[bf4]

Or if @exit_status && @exit_status > 0

[mszyndel]

You're right, checked just now and SystemExit#status is a Fixnum

[colszowka]

Very nice, thank you! I had somehow thought this was not complete yet and didn't merge, thanks for pointing out this is a ready fix!

[mszyndel]

@colszowka I must admit I didn't add any test (and I feel like I should), but have no idea how to write such test do be honest.

[colszowka]

An idea would be to pull the at_exit logic into a class and then unit test that throughly, like this:

class SimpleCov::ExitHandler
  def handle_exit(status)
     if status == 0
       do_exit 0
    end
  end

  def do_exit(status)
      exit status
  end
end

This would allow to verify that any given input to the handle_exit method will call do_exit with the expected status, without actually killing the testing process by expecting the call on do_exit with a correct status without actually executing it.