New interface to specify multiple formatters

[sferik]

This is the implementation of my proposal for a new multiple formatter interface. To restate:

SimpleCov.formatters = [
  SimpleCov::Formatter::HTMLFormatter,
  SimpleCov::Formatter::CSVFormatter,
]

This is the current interface:

SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
  SimpleCov::Formatter::HTMLFormatter,
  SimpleCov::Formatter::CSVFormatter,
]

I think my proposal is better than the current interface because (conventionally) the [] method is used to fetch a value, not to set a value.

This proposal would not require breaking the current interface SimpleCov.formatter because the new method is named SimpleCov.formatters (with an “s”).

I’ve left the decision to deprecate SimpleCov::Formatter::MultiFormatter.[] up to the maintainers. IMHO, a version of simplecov should be released with a much simpler interface. For example, I find it a bit strange that SimpleCov.formatter is both a setter and a getter, when there is also an explicit SimpleCov.formatter= attribute writer. I’m not sure why the setter needs to be spelled two different ways.

[bf4]

Would you mind adding yourself to the CHANGELOG? Thanks. If you're up for coming on board as a collaborator, I'm happy to ask @colszowka

[sferik]

I’ve added this change to the CHANGELOG. Let me know if you want me to squash that into the previous commit.

As for joining as a collaborator, I would be honored to be a member of the team, if @colszowka will have me. I maintain a number of other Ruby projects, so I can’t promise that I will have much free time to dedicate to simplecov but I will contribute when I can.

[colszowka]

Sure thing, added you @sferik - welcome aboard and thanks for the suggestion @bf4!

[bf4]

@sferik The way I see it, is anyone making regular quality PR's should be invited as a collab as a way of saying "keep doing what you're doing; I trust you". It helps grease the wheel of progress :) Which is why I have commit on some projects I don't commit much too.... ;)

[bf4]

Y'know, I forgot that we should update the README as well.

[sferik]

@bf4 I can update the README now that I have a commit bit. 😄

[bf4]

Since it's somewhat on topic, @colszowka please also add @xaviershay as collaborator

[colszowka]

Done, welcome on board @xaviershay :)

[sferik]

@xaviershay Welcome to the team! 😄

[xaviershay]

wooo