Conversation
Collaborator
Author
|
I wanted to put up some thoughts for discussion. Other collabs can please work on this (or close it) as I'm taking a break. |
Collaborator
Author
|
s/taking a break/just had a baby on Sunday... availability will be spotty |
Collaborator
|
Wohoo, congrats @bf4! I know that feel, enjoy it and thanks for the heaps of time you put in recently! |
Collaborator
Author
|
Thanks.. :) |
Collaborator
|
I’m 👍 for adding a warning about JRuby but please rebase this pull request so it doesn’t contain the changes to the |
Collaborator
|
Never mind. I’ve cherry-picked 057360d. |
Collaborator
Author
|
@sferik thanks! |
yous
added a commit
to yous/raheui
that referenced
this pull request
Jul 26, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #174 and #86
JRuby Coverage still has issues in the 1.7 series
@headius any ideas?