Skip to content

Fixing files warnings #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vsoch wants to merge 2 commits into from
Closed

Fixing files warnings #105

vsoch wants to merge 2 commits into from

Conversation

@vsoch
Copy link
Member

@vsoch vsoch commented May 24, 2019

This will fix issues #101 and #102, specifically:

  • we check that the parent of a files source or destination AND the source destination doesn't exist to issue a warning. Previously, we were issuing a warning if the destination didn't exist, which isn't logical. It won't :)
  • we give the user a warning for any file expansions (*) as Singularity doesn't allow this.

Signed-off-by: Vanessa Sochat vsochat@stanford.edu

@vsoch
fixing files warnings
6b86cb9 
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch
Copy link
Member Author

vsoch commented May 24, 2019

@Flamefire would you care to test this? It addresses your two issues about files warnings.

@vsoch
removing check for dest
11b49ef 
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch
Copy link
Member Author

vsoch commented May 25, 2019

okay, just checking the source now!

@Flamefire Flamefire mentioned this pull request May 27, 2019
Merged
@vsoch
Copy link
Member Author

vsoch commented May 27, 2019

The lines in this PR were copy pasted by @Flamefire, now under his name. Closing.

@vsoch vsoch closed this May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vsoch