adding test for entrypoint+cmd and adding proper testing requirements #129
Conversation
… (will need to be in conda too) Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
|
|
||
| TESTS_REQUIRES = ( | ||
| ('pytest', {'min_version': '4.6.2'}), | ||
| ('pytest-cov', {'min_version': '2.5.1'}), |
There was a problem hiding this comment.
Should not be required
But will be needed on CI if coverage is added
There was a problem hiding this comment.
So thinking ahead! Without realizing it :)
| TESTS_REQUIRES = ( | ||
| ('pytest', {'min_version': '4.6.2'}), | ||
| ('pytest-cov', {'min_version': '2.5.1'}), | ||
| ('pytest-fixtures', {'min_version': '0.1.0'}), |
| ) | ||
|
|
||
| TESTS_REQUIRES = ( | ||
| ('pytest', {'min_version': '4.6.2'}), |
There was a problem hiding this comment.
Something like 4.0.0 should already be enough
| Bootstrap: docker | ||
| From: busybox:latest | ||
| %runscript | ||
| exec python /code/script.py "$@" |
There was a problem hiding this comment.
This is an inexact translation of the Dockerfile. See #111 (comment)
There was a problem hiding this comment.
Yes but this is what works and is expected for Singularity. You don't see users writing /bin/bash -c "..." as this is handled internally in Singularity.
There was a problem hiding this comment.
Completely missing the point. docker run entrypoint-cmd --foo does a python --foo not a python /code/script.py --foo
There was a problem hiding this comment.
It will need to be fixed then.
The testing requirements were not fully represented in the setup.py. I'm worried now that there are too many additional dependencies to run basic testing, and perhaps this will come back to bite me. For the meantime the damage is already done, and I'll need to update conda deps too. Right now as is, a user only thinks that pytest is required and won't understand why many of the tests fail. This will also add a test for the entrypoint+cmd conversion in a Dockerfile to Singularity recipe.
I will need to update conda too.
Signed-off-by: Vanessa Sochat vsochat@stanford.edu