-
-
Notifications
You must be signed in to change notification settings - Fork 31
adding test for entrypoint+cmd and adding proper testing requirements #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Bootstrap: docker | ||
| From: busybox:latest | ||
| %runscript | ||
| exec python /code/script.py "$@" | ||
| %startscript | ||
| exec python /code/script.py "$@" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| FROM busybox:latest | ||
| CMD ["/code/script.py"] | ||
| ENTRYPOINT ["python"] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ | |
| # with this file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
|
||
|
|
||
| __version__ = "0.0.65" | ||
| __version__ = "0.0.66" | ||
| AUTHOR = 'Vanessa Sochat' | ||
| AUTHOR_EMAIL = 'vsochat@stanford.edu' | ||
| NAME = 'spython' | ||
|
|
@@ -18,3 +18,9 @@ | |
| INSTALL_REQUIRES = ( | ||
| ('semver', {'min_version': '2.8.0'}), | ||
| ) | ||
|
|
||
| TESTS_REQUIRES = ( | ||
| ('pytest', {'min_version': '4.6.2'}), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Something like 4.0.0 should already be enough |
||
| ('pytest-cov', {'min_version': '2.5.1'}), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should not be required
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So thinking ahead! Without realizing it :) |
||
| ('pytest-fixtures', {'min_version': '0.1.0'}), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not required |
||
| ) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an inexact translation of the Dockerfile. See #111 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but this is what works and is expected for Singularity. You don't see users writing /bin/bash -c "..." as this is handled internally in Singularity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely missing the point.
docker run entrypoint-cmd --foodoes apython --foonot apython /code/script.py --fooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will need to be fixed then.