Add library:// url support in spython build/pull #154
Conversation
|
Looks like circle changed something to need extra permission to use the Orb, and it's buggy! I'm seeing if I can fix this up. |
|
@vsoch Yeah. Thanks a lot. |
|
While we are waiting, please update the version.py (version in there) and a matching line in the CHANGELOG.md. If the circle issue doesnt resolve, I'll pull your changes and PR from my branch, in case that works. |
|
Done @vsoch |
|
okay, the page seems to load (and I have the setting checked) so it must have issue with running the test since you aren't an org member. I'm going to go ahead and pull the branch and open in a PR and see if that works. Your changes look great and spot on, btw, it's just good to get testing done! If this is a new issue with using Circle orbs I'll need to think about how to address this in the future.
Anyway stay tuned! |
|
Merged with #156, thanks @JayjeetAtGithub ! I'll get the release ready for pypi now. |
2 participants
Add support for
library://URLs in spython build and pull #155